Repository navigation
Fix smart-flow resource routing for URLs with query strings - #499
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Smart-flow resource matching currently runs against the entire URL. A request to
/networks/N_1?perPage=10looks upN_1?perPage=10instead of the cached networkN_1; an organization URL with a query similarly gets a separate rate-limit bucket. A resource-looking URL inside a query parameter can also take precedence over the actual path.Match resource IDs against the parsed path in both synchronous and asynchronous routing, background resolution, and response learning. Add 24 regression cases covering query strings, fragments, misleading query paths, resolver arguments, and learned mappings. All 24 fail before the fix.
Validation: all 514 unit tests pass with 94.12% core coverage (90% required). CI's Ruff lint and formatting checks pass with the locked Ruff 0.15.22. Includes a changelog fragment.