fix(nrf52): time out BLE connections that never complete pairing (revives #2089) - #3263
Open
dotspencer wants to merge 2 commits into
Open
fix(nrf52): time out BLE connections that never complete pairing (revives #2089)#3263dotspencer wants to merge 2 commits into
dotspencer wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revives #2089 by @ipduffy
Bug: client that connects but never completes encryption (seems to be common with iOS) holds node's only peripheral slot forever. Nothing times it out, and advertising watchdog skips any state where _conn_handle is set, so node stops advertising until it's power-cycled.
Fix: drop a connection that hasn't secured within 15s and resume advertising. nRF52 only.
Testing: RAK4631,
RAK_4631_companion_radio_ble. On stock firmware an unpairedbleakconnection from a Mac holds the slot indefinitely. With patch the node drops it after ~13s and resumes advertising.