Conversation
Replace Pyre configuration and lint integration with Pyrefly 1.2.0, remove obsolete directives, and resolve reported typing issues. Test plan: - pyrefly check --config pyrefly.toml - lintrunner --skip PYREFLY,FLAKE --all-files - lintrunner --take PYREFLY --all-files - cargo +nightly fmt --check - cargo test -v - pytest -v --reruns 3 --reruns-delay 5 - maturin build --release
meta-cla
Bot
added
the
CLA Signed
|
This pull request has been imported. If you are a Meta employee, you can view this in D117807028. (Because this pull request was imported automatically, there will not be any future comments.) |
maggiemoss
approved these changes
Aug 28, 2026
maggiemoss
left a comment
maggiemoss
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace Pyre configuration and lint integration with Pyrefly 1.2.0, remove obsolete directives, and resolve reported typing issues.
Test plan:
pyrefly check --config pyrefly.tomllintrunner --skip PYREFLY,FLAKE --all-fileslintrunner --take PYREFLY --all-filescargo +nightly fmt --checkcargo test -vpytest -v --reruns 3 --reruns-delay 5(150 passed, 59 skipped; one Gloo timeout failed, isolated rerun passed)maturin build --release