Skip to content

fix(deps): require cmdstanpy 1.3.2 so Windows source builds stop fetching a retired Rtools URL - #2784

Open
iruzen-dono wants to merge 2 commits into
meta:mainfrom
iruzen-dono:fix/cmdstanpy-rtools-floor
Open

iruzen-dono wants to merge 2 commits into
meta:mainfrom
iruzen-dono:fix/cmdstanpy-rtools-floor

Conversation

@iruzen-dono

Copy link
Copy Markdown

Fixes #2777

What

cmdstanpy floor raised from >=1.0.4 to >=1.3.2 in python/pyproject.toml, in both places the file declares it:

  • [build-system] requires — the editable install that fails is a build-system requirement, so the floor has to be there or the build can still resolve 1.3.0.
  • [project] dependencies — a source install from metadata must not permit the broken release either.

Why 1.3.2

cmdstanpy RTools URL reachable
1.3.0 cran.r-project.org/bin/windows/Rtools/rtools40-x86_64.exe 404
1.3.2 cran-archive.r-project.org/bin/windows/Rtools/rtools40-x86_64.exe 200

1.3.2 is the latest on PyPI and requires python >=3.9, so this project's >=3.10 is unaffected.

Verification

The dependency graph resolves to the intended release, and the rest of the metadata is untouched:

$ uv pip compile - <<'EOF'
cmdstanpy>=1.3.2
numpy>=1.21.6
matplotlib>=3.5.3
pandas>=1.3.5
holidays>=0.25,<1
tqdm>=4.63.2
EOF
Resolved 18 packages in 2.87s
cmdstanpy==1.3.2

python -c "import tomllib; tomllib.load(open('python/pyproject.toml','rb'))" parses, and both declarations carry the new floor.

I could not run the Windows build itself here (it compiles the Stan model), so the CI job is the real check: build-and-test-python (3.12, windows-latest) should now fetch RTools from cran-archive instead of dying.

Not in this PR

The reporter's other suspicion — the runner's pip cache being why 1.3.0 won the resolution — is left alone. Clearing the Actions cache is a maintainer action, and pinning in CI instead would leave the package metadata wrong for everyone installing from a checkout.

AI disclosure

Prepared with an AI agent (Hermes), reviewed before submission.

…hing a retired Rtools URL

`cmdstanpy` 1.3.0 downloads the RTools 4.0 installer from
`cran.r-project.org/bin/windows/Rtools/rtools40-x86_64.exe`, which CRAN retired
(HTTP 404). 1.3.2 uses `cran-archive.r-project.org`, which still serves it. The
metadata asked for `>=1.0.4`, so a stale pip cache on the runner resolved 1.3.0
and every Windows source/editable build died while compiling the Stan model,
before a single test ran.

The floor moves to `>=1.3.2` in both places the file declares it: the build
system's `requires` (used by the editable install that failed) and the project
dependencies. 1.3.2 supports Python >=3.9, so the `>=3.10` this project already
requires is unaffected.

The Actions-cache side of the report is a maintainer call; this change only
makes the metadata stop permitting the broken release.
Copilot AI balanced review requested due to automatic review settings November 12, 2026 20:28
@meta-cla

meta-cla Bot commented Nov 12, 2026

Copy link
Copy Markdown

Hi @iruzen-dono!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@meta-cla meta-cla Bot added the CLA Signed label Nov 12, 2026
@iruzen-dono

Copy link
Copy Markdown
Author

Ready for review.

The dependency floor is the whole change: cmdstanpy>=1.3.2 in [build-system] requires and in [project] dependencies. The CLA is signed, so the only gate left on this one is a maintainer's read.

Why it is the right floor: 1.3.0 fetches RTools 4.0 from cran.r-project.org/bin/windows/Rtools/rtools40-x86_64.exe (410/404 since CRAN retired it), 1.3.2 uses cran-archive. uv pip compile on the six project dependencies resolves cmdstanpy==1.3.2, and 1.3.2 requires Python >=3.9 against this project's >=3.10.

The build-and-test-python (3.12, windows-latest) job is the real proof — it should now fetch the toolchain and get past the editable install.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows source builds fail: cmdstanpy 1.3.0 downloads Rtools40 from a retired CRAN URL (HTTP 404)

2 participants