Repository navigation
fix(release): publish without deltas when BinaryDelta cannot diff the app - #808
Merged
Merged
Conversation
… app MetalSharp-Wine-x86_64.app ships .dSYM files whose code signatures are in extended attributes, and BinaryDelta refuses such a tree on either side of a delta. v1.4.0 was the regular build's first release with an earlier Sparkle archive, so its release job failed making the delta from 1.3.0. sparkle_release.py now looks for those attributes first: an app that has them gets no deltas, and an older release that has them gets none from it. The log names the file, and Sparkle installs the full archive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v1.4.0 Release CI failed in Build DMG → Sparkle update (archive, deltas, appcast):
Cause.
MetalSharp-Wine-x86_64.appships 82.dSYMDWARF files whose code signatures are kept in extended attributes (7.0 and 8.0 both). Sparkle'sBinaryDeltarefuses such a tree as either side of a delta. 1.4.0 is the regular build's first release with an earlier Sparkle archive (1.3.0), so this is the first time it tried. The FEX build has no such files and made its delta.Change.
tools/sparkle/sparkle_release.py publishchecks for those attributes before making deltas:The log names the file each time. The appcast then lists the full archive only, which Sparkle installs. A delta that is made must still apply and verify, or the release stops, as before.
Not changed. The regular build gets delta updates again only once MetalSharp Wine's x86_64 app stops shipping those
.dSYMfiles; MetalSharp carries that app unmodified.Checks.
python3 -m unittest tools.sparkle.tests.test_sparkle_release(new test, macOS only); the new check findsopt.dSYM/…/opt64in the published MetalSharp-Wine-8.0 x86_64 app and nothing in an installed FEX MetalSharp.app. The release job itself is proven by re-running the v1.4.0 release after merge.