Skip to content

fix(release): publish without deltas when BinaryDelta cannot diff the app - #808

Merged
aaf2tbz merged 2 commits into
mainfrom
fix/sparkle-delta-signed-xattrs
Nov 18, 2026
Merged

aaf2tbz merged 2 commits into
mainfrom
fix/sparkle-delta-signed-xattrs

Conversation

@aaf2tbz

@aaf2tbz aaf2tbz commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator

The v1.4.0 Release CI failed in Build DMG → Sparkle update (archive, deltas, appcast):

Diffing code signed extended attributes are not supported. Detected extended attribute in before-tree on file
…/old-1.3.0/MetalSharp.app/Contents/Resources/MetalSharp-Wine-x86_64.app/Contents/share/metalsharp/runtime/mono-x86/bin/gdbus.dSYM/…

Cause. MetalSharp-Wine-x86_64.app ships 82 .dSYM DWARF files whose code signatures are kept in extended attributes (7.0 and 8.0 both). Sparkle's BinaryDelta refuses such a tree as either side of a delta. 1.4.0 is the regular build's first release with an earlier Sparkle archive (1.3.0), so this is the first time it tried. The FEX build has no such files and made its delta.

Change. tools/sparkle/sparkle_release.py publish checks for those attributes before making deltas:

  • the new app has them → no deltas, and the older archives are not downloaded;
  • an older release's app has them → no delta from that release.

The log names the file each time. The appcast then lists the full archive only, which Sparkle installs. A delta that is made must still apply and verify, or the release stops, as before.

Not changed. The regular build gets delta updates again only once MetalSharp Wine's x86_64 app stops shipping those .dSYM files; MetalSharp carries that app unmodified.

Checks. python3 -m unittest tools.sparkle.tests.test_sparkle_release (new test, macOS only); the new check finds opt.dSYM/…/opt64 in the published MetalSharp-Wine-8.0 x86_64 app and nothing in an installed FEX MetalSharp.app. The release job itself is proven by re-running the v1.4.0 release after merge.

… app

MetalSharp-Wine-x86_64.app ships .dSYM files whose code signatures are in
extended attributes, and BinaryDelta refuses such a tree on either side of a
delta. v1.4.0 was the regular build's first release with an earlier Sparkle
archive, so its release job failed making the delta from 1.3.0.

sparkle_release.py now looks for those attributes first: an app that has them
gets no deltas, and an older release that has them gets none from it. The log
names the file, and Sparkle installs the full archive.
@aaf2tbz
aaf2tbz merged commit 9f1435f into main Nov 18, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant