Repository navigation
fix(ios): declare AVFoundation framework in podspec - #18
Merged
Merged
Conversation
Contributor
|
LGTM! Thanks for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17.
Cause.
RNSpeech.mmusesAVSpeechSynthesizerandAVAudioSession(AVFoundation), butRNSpeech.podspecdoesn't declare the framework. Withuse_frameworks! :linkage => :dynamicthe pod is linked as its own framework, so the link fails withUndefined symbols: _AVAudioSessionCategoryPlayback(and other AVAudioSession constants). Static linkage hides this because the app's final link already includes AVFoundation.Fix. Add
s.frameworks = "AVFoundation"to the podspec.Compatibility. No code changes. For static linkage nothing changes in practice, since AVFoundation was already linked by the app.
Verification. We use this exact change as a local patch on 1.4.3 in our app (React Native 0.86.3, New Architecture,
use_frameworks! :linkage => :dynamic), and the app links again. I also checked this repo's example app withUSE_FRAMEWORKS=dynamic: the build fails without the change and succeeds with it.Drafted with help from Claude (AI), reviewed by me.