fix(gateway): enforce administrative and transport security boundaries - #4964
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9b0978f715
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A focused audit found inconsistent authorization and browser isolation across the dashboard and MCP transports. Require a current administrator role for dashboard account/token/scope management, use context-aware HTML escaping and text-only form responses, and reject foreign browser origins by default with an exact-origin opt-in for trusted MCP clients.
Apply the configured authentication callback to streamable HTTP and WebSocket upgrades. Reinspect WebSocket credentials per tool call, and require the HTTP payment path for priced tools. Document proxy/origin configuration and the administrative boundary.
Validation: dashboard/MCP/origin package tests pass (explicit always-on sampling for in-memory tracing assertions), repository build and lint pass. Regression coverage includes user/service/admin roles and demotion, all dashboard templates, browser origins across transports, authentication callbacks, revoked credentials, and paid WebSocket calls.
Related to the audit prompted by #4925 and #4926. These issues remain open: their private reports have not been received, so this independently verified work does not claim to resolve the reporter's undisclosed findings.