Repository navigation
fix: format paths before basename matching - #225
Draft
vhinayindia wants to merge 1 commit into
Draft
vhinayindia wants to merge 1 commit into
vhinayindia wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Apply
options.formatbefore extracting the basename whenbasenameor itsmatchBasealias is enabled.The format documentation says strings are formatted before matching.
picomatch.test()already calculates the formattedoutput, but currently passes the originalinputtomatchBase():Use that already-formatted output for basename matching, just as the full-path regex branch does. Reject an empty formatted basename so it cannot be coerced into the string
undefined. This also lets callbacks normalize path separators before the basename is extracted. The original input and full formatted output remain available in match results.Validation
Reproduced on current master
9fab7bf(picomatch 4.0.7), Linux, Node 24.19.0, with synthetic strings only.npm test: ESLint passes, 2,008 tests pass.npm run test:ci: 2,008 tests pass with coverage.git diff --check: clean.The full Node/OS CI matrix has not been run locally. No dependency changes.