Repository navigation
fix: populate single-segment scan tokens - #230
Open
JunaidAhamed-7777 wants to merge 1 commit into
Open
JunaidAhamed-7777 wants to merge 1 commit into
JunaidAhamed-7777 wants to merge 1 commit into
Conversation
JunaidAhamed-7777
marked this pull request as ready for review
October 13, 2026 17:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
scan()receives{ tokens: true }, a single-segment pattern such as*.jsor**currently returns an empty token with depth zero. The same finalization gap affects a segment immediately after./or a leading slash. This makes**reportmaxDepth: 0instead ofInfinity.Finalize the last token using the computed segment start, while checking that a terminal token exists. Add regressions for ordinary and negated segments, globstars, prefixes, leading slashes, empty inputs, trailing separators, and escaped terminal slashes. Default scanning and matching are unchanged.
Validation:
npm test: ESLint passed; 2,004 tests passed.npm run test:ci: 2,004 tests passed with coverage.Human review follows draft submission.