Repository navigation
Conversation
|
See #235 (comment). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes GHSA-fc5q-39xc-vjpf / CVE-2026-112366.
analyzeRepeatedExtglobskipped single-branch repeated extglobs such as+(*)or+(*a), so they compiled to nested unbounded quantifiers (e.g.(?:[^/]*?a)+), causing exponential backtracking on short inputs.Fix
A single branch containing a top-level
*(with no/, groups, alternation, nested extglobs or globstar) absorbs its own repetition, so:+(P)→(?:P)*(P)→(?:P)?These are semantically equivalent and remove the nested quantifier. Other cases keep the existing risky-extglob handling. The rewrite is skipped when
maxExtglobRecursion: false.+(*a)(?:[^/]*?a)+(?:[^/]*?a)*(*a)(?:[^/]*?a)*(?:[^/]*?a)?Before the fix, matching
'a'.repeat(24) + 'b'against+(*a)took ~107ms and doubled with each extra char. With the fix it takes ~0ms.Tests
Added cases in
test/options.maxExtglobRecursion.jscovering:+(*)c,+(*a),+(a*b),*(*.js))All 1999 tests pass.