Skip to content

Consolidate Tier 1 agent guidance - #6

Merged
Cj-Scott merged 3 commits into
mainfrom
npf-tier1-context-consolidation
Sep 23, 2026
Merged

Cj-Scott merged 3 commits into
mainfrom
npf-tier1-context-consolidation

Conversation

@Cj-Scott

Copy link
Copy Markdown
Collaborator

Summary

  • Make AGENTS.md the single master entry point with an explicit authority map and links to detailed guidance.
  • Move the existing Copilot instructions into docs/conventions.md, preserve deployment safeguards and commands, and reduce .github/copilot-instructions.md to a pointer.
  • Document static-versus-pilot validation boundaries and include a scoped Responsible AI review. Product scripts, configuration, and canonical telemetry instructions are unchanged.

Readiness evidence

The direct review against the NPF plugin's published Tier 1 criteria found duplicated context (criterion 2). This change removes that duplication while keeping verification and coverage guidance reachable from the root (criteria 5 and 11). This is not a completed 40-criterion plugin scan or published tracker telemetry. Re-scan the merged default branch before preparing the tracker payload.

Validation

  • Maintainer quality gate: passed, zero errors and warnings.
  • pwsh -NoProfile -File .\scripts\verify.ps1: passed; 11 PowerShell files parsed and PurviewConfig.psd1 validated.
  • Changed-document local links and section anchors resolve.
  • Original detailed instructions preserved apart from the replaced title and validation introduction.
  • Canonical telemetry file unchanged; git diff --check passed.
  • No tenant calls or pilot validation; this change only reorganizes documentation.

Branch routing and review

The documented staging branch does not exist on origin. The repository owner explicitly approved targeting main for this adoption PR. Human review and merge approval remain required; no telemetry has been published.

source-skill: smb-best-practice-maintainer (direct adoption using NPF published criteria)
source-org: cxe
model: gpt-6-astra
tokens-consumed: input=unknown, output=unknown, total=unknown

assistance: agentic-cli
type: docs
agent-tool: copilot-cli
agent-model: gpt-6-astra
work-item: AB#n/a

Make AGENTS.md the shared entry point and keep detailed guidance in one canonical document so agent clients do not follow drifting copies. Preserve deployment safeguards and telemetry instructions.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@Cj-Scott
Cj-Scott requested review from a team and a lite review from Copilot September 23, 2026 15:46
@Cj-Scott Cj-Scott added agentic-cli Work primarily authored by a terminal AI agent docs Documentation changes labels Sep 23, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Unresolved issues remain in WhatIf connection guidance and branch-routing instructions.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 2 Medium severity

Open (2)
What changed in this PR

This documentation-only PR consolidates Tier 1 agent guidance under AGENTS.md.

Changes:

  • Centralizes detailed conventions in docs/conventions.md.
  • Reduces Copilot instructions to a pointer.
  • Adds a scoped Responsible AI review.
File Summary
docs/​Responsible-AI-Review.md Documents the scoped Responsible AI assessment.
docs/​conventions.md Centralizes repository, validation, architecture, and workflow guidance.
AGENTS.md Defines the master guidance entry point and authority map.
.github/​copilot-instructions.md Redirects users to AGENTS.md.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread docs/conventions.md Resolved
Comment thread docs/conventions.md Resolved
Clarified usage of -WhatIf for deployment tasks and added example.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings September 23, 2026 15:52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

Update the canonical workflow to remove the nonexistent staging branch reference.

Review effort: Lite
Findings: 1 Medium severity

Open (1)
Resolved since last review (1)

Copilot AI review requested due to automatic review settings September 23, 2026 15:55

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

Resolve the documented guidance inconsistencies before approval.

Review effort: Lite
Findings: None

Resolved since last review (1)

@Cj-Scott
Cj-Scott merged commit a5d2b6c into main Sep 23, 2026
2 checks passed
@Cj-Scott
Cj-Scott deleted the npf-tier1-context-consolidation branch September 23, 2026 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agentic-cli Work primarily authored by a terminal AI agent docs Documentation changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants