Repository navigation
Adding subview_mut to MatrixMut - #1463
Merged
Merged
Conversation
Aditya Krishnan (arkrishn94)
requested review from
a team
and
a balanced review from Copilot
October 6, 2026 18:18
Copilot started reviewing on behalf of
Aditya Krishnan (arkrishn94)
October 6, 2026 18:18
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The implementation preserves existing layout and borrowing contracts, with tests covering range validation and nested writes.
Review effort: Balanced
Findings: None
What changed in this PR
Adds mutable row subviews to MatrixMut, enabling bulk writes into selected matrix rows.
Changes:
- Adds
subview_mutwith range validation. - Extends tests for boundary cases, zero-column matrices, and nested mutations.
| File | Description |
|---|---|
diskann-utils/src/views/rowmajor.rs |
Implements mutable subviews and extends subview tests. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Mark Hildebrand (hildebrandmw)
approved these changes
Oct 6, 2026
Magdalen Dobson Manohar (magdalendobson)
approved these changes
Oct 6, 2026
Aditya Krishnan (arkrishn94)
enabled auto-merge (squash)
October 6, 2026 18:23
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1463 +/- ##
=======================================
Coverage 91.92% 91.92%
=======================================
Files 583 583
Lines 115876 115903 +27
=======================================
+ Hits 106523 106549 +26
- Misses 9353 9354 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a
subview_mutmethod to the recently addedMatrixMuttrait so that we can copy data in bulk into "subviews" of a mutable matrix.So copying data from a
ref: Ref<'_, T>into amut: Mut<'_, T>can be done with something like this -