Skip to content

Fix/codeql secure random #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Babak (babaknaderi) merged 2 commits into from
Oct 8, 2026
Merged

Fix/codeql secure random #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27becec
Use secure randomness for browser identifiers
babaknaderi Oct 8, 2026
efbe08c
Preserve session identifier length
babaknaderi Oct 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/template/ACRHR_template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@

**/
function initializeActivePageMonitoring(){
sessionId = Math.random().toString(36).substr(2, 9);
sessionId = Array.from(crypto.getRandomValues(new Uint8Array(5)), byte => byte.toString(16).padStart(2, "0")).join("").slice(0, 9);
sessionIdVariableName = config.qualificationCookieName +"_sid";
createCookie(sessionIdVariableName,sessionId,70);

Expand Down
2 changes: 1 addition & 1 deletion src/template/ACR_template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@
// not more than 2min loading time is acceptable despite the internet speed test and file size
page_loading_timer = setTimeout(show_message_too_long_loading, 120*1000);

sessionId = Math.random().toString(36).substr(2, 9);
sessionId = Array.from(crypto.getRandomValues(new Uint8Array(5)), byte => byte.toString(16).padStart(2, "0")).join("").slice(0, 9);
sessionIdVariableName = config.qualificationCookieName +"_sid";
createCookie(sessionIdVariableName,sessionId,70);

Expand Down
2 changes: 1 addition & 1 deletion src/template/DCR_template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@
page_loading_timer = setTimeout(show_message_too_long_loading, 120*1000);


sessionId = Math.random().toString(36).substr(2, 9);
sessionId = Array.from(crypto.getRandomValues(new Uint8Array(5)), byte => byte.toString(16).padStart(2, "0")).join("").slice(0, 9);
sessionIdVariableName = config.qualificationCookieName +"_sid";
createCookie(sessionIdVariableName,sessionId,70);

Expand Down
2 changes: 1 addition & 1 deletion src/template/avatar_template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@
// not more than 2min loading time is acceptable despite the internet speed test and file size
page_loading_timer = setTimeout(show_message_too_long_loading, 120*1000);

sessionId = Math.random().toString(36).substr(2, 9);
sessionId = Array.from(crypto.getRandomValues(new Uint8Array(5)), byte => byte.toString(16).padStart(2, "0")).join("").slice(0, 9);
sessionIdVariableName = config.qualificationCookieName +"_sid";
createCookie(sessionIdVariableName,sessionId,70);

Expand Down
Loading