Secure EncryptCredentials datasource endpoints - #244
Open
KupoCat wants to merge 3 commits into
Open
Conversation
Require an assigned Entra app role for privileged datasource operations, add CSRF protection, and return fail-closed API authorization responses. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Replace the controller metadata assertion with integration coverage proving authenticated datasource administrators can access every protected endpoint. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Remove the test project and restore the production service methods that were made virtual only for test substitution. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PowerBI.DatasourceAdminapp role for the EncryptCredentials UI and privileged datasource endpoints401/403API responses and protect state-changing requests with antiforgery tokensValidation
dotnet test ".NET Core\EncryptCredentials\EncryptCredentials.sln" --configuration Release(8 tests passed)dotnet list ".NET Core\EncryptCredentials\EncryptCredentials\EncryptCredentials.csproj" package --vulnerable --include-transitive(no vulnerable packages)