Skip to content

Enable GDK 2604.4.7897 for installed and vcpkg builds - #208

Open
James Lenell (jameslen-atg) with Copilot wants to merge 3 commits into
mainfrom
copilot/assess-addon-support-another-one
Open

James Lenell (jameslen-atg) with Copilot wants to merge 3 commits into
mainfrom
copilot/assess-addon-support-another-one

Conversation

Copilot AI commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Summary

copilot/assess-addon-support-another-one enables GDK 2604.4.7897 / edition 260404 (April 2026 Update 4) for installed and hosted vcpkg builds.
Adds the installed-GDK allowlist entry, adds hosted coverage, and promotes Update 4 to the default manifest override and CI/nightly SDK while retaining every previously supported edition.
The port is now published by microsoft/vcpkg#53929; the registry baseline advances to its merge commit, 67df21dd2958eb5909a32a6955265321a5ae8ee0, so the new version is resolvable.

Public API changes

None.

Spec / docs / samples updated

  • spec\gdext-<feature>.md updated (Plan / Progress sections if multi-session work)
  • docs\godot-<addon>-*.md updated
  • addons\<addon>\doc_classes\*.xml updated for any public API change
  • Sample content (sample\<host>\) updated when public addon behaviour changed
  • Path-scoped instruction file (.github\instructions\<addon>.instructions.md) updated if conventions changed
  • Not applicable — no public addon behaviour changed

Test coverage delta

  • Contract (offline) tests added/removed: one support-configuration regression added for edition 260404; updated it to assert both installed and hosted support, the hosted default, and the manifest override. Retained the Update 3 support regression. No GUT cases added or removed.
  • Live-read tests added/removed: 0.
  • Live-write tests added/removed: 0.
  • Live title id used (if any): none; live services and live writes were not enabled.

Validation run

Local Windows validation completed on 2026-10-21 while preparing commit d086448:

cmake --preset default
-> PASS: restored ms-gdk[core,playfab] 2604.4.7897 and configured Debug.

cmake --build --preset debug
-> PASS: godot_gdk, godot_playfab, and godot_gameinput.

cmake --preset default-release
-> PASS: restored ms-gdk[core,playfab] 2604.4.7897 and configured the separate Release tree.

cmake --build --preset release
-> PASS: godot_gdk, godot_playfab, and godot_gameinput.

$env:GODOT_CONSOLE = (Resolve-Path -LiteralPath '.\Godot\Godot_v4.6.1-stable_win64_console.exe').Path
pwsh -NoLogo -NoProfile -ExecutionPolicy Bypass -File .\tools\run_all_tests.ps1 -OutDir 'build\test-results\gdk-260404-offline'
-> PASS: Overall: pass, using stock Godot 4.6.2.stable.official.71f334935.
   The executable reports 4.6.2 despite its filename.
   Parse gate and Debug rebuild passed.
   C++ doctest: 16 passed, 0 failed.
   GUT GDK: 323 passing, 16 pending, 0 failed.
   GUT PlayFab: 128 passing, 23 pending, 0 failed.
   GUT GameInput: 53 passing, 7 pending, 0 failed.
   Bootstrap: all 13 runners passed.
   Live multiplayer orchestrator: skipped because -Live was not set.

node --test tools\ci\tests\gdk_release_watch.test.cjs tools\ci\tests\gdk_release_assess.test.cjs
-> PASS: 95 passed, 0 failed.

Both Debug and Release vcpkg trees were checked directly: share\ms-gdk\vcpkg.spdx.json reports 2604.4.7897, and include\grdk.h defines _GRDK_EDITION as 260404.
The local orchestrator report is build\test-results\gdk-260404-offline\run-summary.md.
No .gd files changed; the full offline orchestrator nevertheless ran the headless parse gate.

Not run: the installed-gdk preset against a machine-wide Update 4 install, the full supported Godot engine matrix locally, live reads, or live writes (-Live and -AllowLiveWrites were not used). The results above establish published-vcpkg Debug/Release builds and offline coverage on Godot 4.6.2, not live-service compatibility.

Migration notes

None.

Co-authored-by: jameslen-atg <24258495+jameslen-atg@users.noreply.github.com>
Copilot AI changed the title [WIP] Assess addon support for GDK 2604.4.7897 Allow installed GDK 2604.4.7897 selection Oct 16, 2026
Pin ms-gdk 2604.4.7897 at the upstream Update 4 registry commit. Add edition 260404 to the hosted matrix and make it the default so CI does not override the manifest back to Update 3. Keep Update 3 supported and align the support-state regression tests.

Local validation: Debug and Release configure/build passed for all three native addons. The offline orchestrator passed on Godot 4.6.2 (parse gate, 16 C++ tests, 504 passing GUT tests, 46 pending, and 13 bootstrap runners). GDK watcher/assessor tests: 95 passed. No GDScript files changed; live tests and live writes were not run.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: ac094434-56a5-4509-a322-1b854716b04e
@jameslen-atg
James Lenell (jameslen-atg) marked this pull request as ready for review October 21, 2026 16:58
@jameslen-atg
James Lenell (jameslen-atg) requested review from a team and a balanced review from Copilot October 21, 2026 16:58

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Promoting the default SDK requires human confirmation of real-SDK build and live-test evidence.

1 open issue
What changed in this PR

Enables GDK 2604.4.7897 for installed and hosted builds and promotes it as the default vcpkg SDK.

Changes:

  • Adds installed edition 260404 and hosted coverage.
  • Updates the default SDK and registry baseline.
  • Extends support-state regression tests.
File Description
vcpkg.json Updates the default GDK override.
vcpkg-configuration.json Advances the registry baseline.
tools/​ci/​tests/​gdk_release_watch.test.cjs Checks installed and hosted support for 260404.
cmake/​GDKDependencies.cmake Allows installed edition 260404.
.github/​gdk-versions.json Adds hosted coverage and updates the nightly default.

Review effort: Balanced

Comment thread .github/gdk-versions.json
@jameslen-atg James Lenell (jameslen-atg) changed the title Allow installed GDK 2604.4.7897 selection Enable GDK 2604.4.7897 for installed and vcpkg builds Oct 21, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GDK 2604.4.7897 (April 2026 Update 4): assess addon support

4 participants