Repository navigation
Fix missing instance ticket token JNI binding - #1552
Open
star-du (star-du) wants to merge 1 commit into
Open
star-du (star-du) wants to merge 1 commit into
star-du (star-du) wants to merge 1 commit into
Conversation
Implement the existing Java native contract through the instance auth tokens controller while preserving status and conversion failures. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Author
|
@microsoft-github-policy-service agree company="Microsoft" |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Calling
ILogManager.setTicketTokenon a manager created byLogManagerProviderthrowsUnsatisfiedLinkError: Java declares the instance native method, but the corresponding JNI entry point is missing.Implement the bridge to the instance auth tokens controller and return its status. Invalid managers or unavailable controllers return
EFAIL; pending Java string-conversion exceptions are preserved. The existing static entry point remains unchanged.Related: #1218 (closed without merging).
Validation
Checked the public Java native declaration and C++ controller contract against the new entry point. The change is limited to
lib/jni/LogManager_jni.cpp.No build or device tests were run against this upstream revision.