Repository navigation
Exclude generated sandbox sources from upstream syncs - #410
Merged
Vladimir Morozov (vmoroz) merged 1 commit intoNov 10, 2026
Merged
Vladimir Morozov (vmoroz) merged 1 commit into
Vladimir Morozov (vmoroz) merged 1 commit into
Conversation
hermes-windows does not ship the sandbox. Its generated wasm2c sources
(API/hermes_sandbox/external/hermes_sandbox_impl_{dbg,opt}_compiled*) are
~200 MB per upstream regeneration, and GitHub cannot diff them in place.
microsoft#408 removed them; list them in .syncignore so future syncs keep them out,
including new file names. The sandbox stays skipped while they are absent.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the generated sandbox source sync exclusion and related documentation updates.
No open issues 🎉
What changed in this PR
Keeps the unshipped sandbox’s large generated wasm2c sources out of future upstream syncs, extending the source removal in #408 while allowing the remaining sandbox code to continue syncing.
Changes:
- Adds a
.syncignorepattern covering generated sandbox sources, including newly numbered files. - Updates contributor guidance and the CMake comment to describe the exclusion and how to re-enable the sandbox; build logic is unchanged.
| File | Description |
|---|---|
| API/CMakeLists.txt | Updates the comment explaining source exclusion and sandbox enablement. |
| AGENTS.md | Replaces the follow-up import guidance with permanent sync-exclusion guidance. |
| .syncignore | Excludes generated wasm2c sandbox sources from upstream syncs. |
Review effort: Balanced
Nikolai Aristov (NikoAri)
approved these changes
Nov 10, 2026
Vladimir Morozov (vmoroz)
enabled auto-merge (squash)
November 10, 2026 01:04
Benchmark ResultsTotal benchmarks: 204 Inputs: baseline/baseline.json, bench_result.json v8 (6176ms, 3204ms) -48.1%
test-suites (317886ms, 166654ms) -47.6%
micros (60876ms, 40972ms) -32.7%
jit-benches (8563ms, 4423ms) -48.3%
many-subclasses (73437ms, 44893ms) -38.9%
map-objects (3627ms, 1033ms) -71.5%
map-strings (4335ms, 1302ms) -70.0%
nbody (3448ms, 1679ms) -51.3%
string-switch (6503ms, 3413ms) -47.5%
raytracer (5608ms, 3232ms) -42.4%
MiniReact (30332ms, 12076ms) -60.2%
widgets (12934ms, 7099ms) -45.1%
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hermes-windows does not ship the Hermes sandbox, and its generated wasm2c sources (
API/hermes_sandbox/external/hermes_sandbox_impl_{dbg,opt}_compiled*) are ~200 MB per upstream regeneration, which GitHub cannot diff in place. #408 removed them and made the build skip the sandbox while they are absent.Keep them out of future syncs
.syncignore, so fork-sync never brings them back, including any new generated file names.API/CMakeLists.txtcomment and the sync note inAGENTS.mdto describe this.Test Plan
git check-ignore --no-indexwith.syncignore(the matching fork-sync uses): excludes the generated_dbg_/_opt_sources, including a new_compiled_8.cname; keeps thehermes_sandbox_impl_compiled_N.cwrappers,wasm-rtfiles andHermesSandboxRuntime.cpp..\dev build --platform x64 --configuration debug: passes; the sandbox is skipped.Microsoft Reviewers: Open in CodeFlow