Skip to content

[202511] MdePkg: PeCoffLib: Record Security Data Directory - #1949

Open
Joey Vagedes (Javagedes) wants to merge 1 commit into
microsoft:release/202511from
Javagedes:personal/joeyvagedes/pecoff-lib
Open

Joey Vagedes (Javagedes) wants to merge 1 commit into
microsoft:release/202511from
Javagedes:personal/joeyvagedes/pecoff-lib

Conversation

@Javagedes

Copy link
Copy Markdown
Contributor

Description

Adds an additional field to PE_COFF_LOADER_IMAGE_CONTEXT that is a copy of the Security Data Directory, if it exists. This field gets set when PeCoffLoaderGetImageInfo is called, if the security data directory exists. It is zerod by default.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

Additional code usage consuming the security data directory and it being correct.

Integration Instructions

N/A

Add a new field, SecurityDataDirectory, to PE_COFF_LOADER_IMAGE_CONTEXT
that records the security data directory of the image. This occurs when
PeCoffLoaderGetImageInfo is called.

Signed-off-by: Joey Vagedes <joey.vagedes@gmail.com>
@Javagedes
Joey Vagedes (Javagedes) force-pushed the personal/joeyvagedes/pecoff-lib branch from a552a01 to 4247948 Compare September 30, 2026 19:57
@Javagedes Joey Vagedes (Javagedes) changed the title MdePkg: PeCoffLib: Record Security Data Directory [202508] MdePkg: PeCoffLib: Record Security Data Directory Sep 30, 2026
@mu-automation

mu-automation Bot commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

⏩ QEMU Validation Skipped

Validation was skipped (reason: wrong_target_branch).

This comment was automatically generated by the Mu QEMU PR Validation workflow.

@codecov-commenter

Codecov Comments Bot (codecov-commenter) commented Sep 30, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 28 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release/202511@ccb1c6a). Learn more about missing BASE report.

Files with missing lines Patch % Lines
MdePkg/Library/BasePeCoffLib/BasePeCoff.c 0.00% 28 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             release/202511    #1949   +/-   ##
=================================================
  Coverage                  ?    2.23%           
=================================================
  Files                     ?     1671           
  Lines                     ?   427122           
  Branches                  ?     5079           
=================================================
  Hits                      ?     9529           
  Misses                    ?   417509           
  Partials                  ?       84           
Flag Coverage Δ
FmpDevicePkg 9.53% <ø> (?)
MdeModulePkg 1.65% <ø> (?)
MdePkg 5.44% <0.00%> (?)
NetworkPkg 0.55% <ø> (?)
PolicyServicePkg 30.42% <ø> (?)
SecurityPkg 1.56% <ø> (?)
StandaloneMmPkg 0.50% <ø> (?)
UefiCpuPkg 4.78% <ø> (?)
UnitTestFrameworkPkg 11.70% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@makubacki

Copy link
Copy Markdown
Member

I assume "202508" was a typo in the PR title?

@Javagedes Joey Vagedes (Javagedes) changed the title [202508] MdePkg: PeCoffLib: Record Security Data Directory [202511] MdePkg: PeCoffLib: Record Security Data Directory Sep 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants