storage: Move PR workaround from SCSI to NVMe - #4455
Merged
Merged
Conversation
See microsoft#4383 for full context. This PR moves the SAS workaround (Host ID starting with 6 0 0 0) from the SCSI code to NVMe.
Alex Landau (alandau)
requested review from
John Starks (jstarks)
and
a lite review from Copilot
September 15, 2026 18:56
Alex Landau (alandau)
marked this pull request as ready for review
September 15, 2026 18:57
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved issues were identified, and the reviewed changes are ready for approval.
Pull request overview
Moves the SAS-derived NVMe Host ID workaround into shared NVMe reservation conversion.
Changes:
- Centralizes Host ID normalization in NVMe handling.
- Removes duplicate SCSI-side workaround logic.
- Adds rate-limited diagnostics and updates dependencies.
File summaries
| File | Description |
|---|---|
vm/devices/storage/scsidisk/src/reservation.rs |
Removes SCSI-local Host ID workaround. |
vm/devices/storage/nvme_common/src/lib.rs |
Normalizes affected NVMe Host IDs. |
vm/devices/storage/nvme_common/Cargo.toml |
Adds tracelimit. |
Cargo.lock |
Records the dependency update. |
Review details
- Files reviewed: 3/4 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
John Starks (jstarks)
approved these changes
Sep 15, 2026
Alex Landau (alandau)
merged commit Sep 16, 2026
4573ce5
into
microsoft:main
147 of 247 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #4383 for full context. This PR moves the SAS workaround (Host ID starting with 6 0 0 0) from the SCSI code to NVMe.