Skip to content

fix(frames): treat elements inside hidden iframes as hidden #42884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dmitry Gozman (dgozman) merged 2 commits into from
Sep 24, 2026
Merged

fix(frames): treat elements inside hidden iframes as hidden #42884

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c96572
fix(frames): treat elements inside hidden iframes as hidden
dgozman Sep 23, 2026
feb1990
chore(frames): require frameVisible for visibility checks
dgozman Sep 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 14 additions & 12 deletions packages/injected/src/injectedScript.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -665,7 +665,7 @@ export class InjectedScript {
return element;
}

async checkElementStates(node: Node, states: ElementState[]): Promise<'error:notconnected' | { missingState: ElementState } | undefined> {
async checkElementStates(node: Node, states: ElementState[], frameVisible: boolean): Promise<'error:notconnected' | { missingState: ElementState } | undefined> {
if (states.includes('stable')) {
const stableResult = await this._checkElementIsStable(node);
if (stableResult === false)
Expand All @@ -675,7 +675,7 @@ export class InjectedScript {
}
for (const state of states) {
if (state !== 'stable') {
const result = this.elementState(node, state);
const result = this.elementState(node, state, frameVisible);
if (result.received === 'error:notconnected')
return 'error:notconnected';
if (!result.matches)
Expand Down Expand Up @@ -753,7 +753,9 @@ export class InjectedScript {
return { queryAll };
}

elementState(node: Node, state: ElementStateWithoutStable): ElementStateQueryResult {
elementState(node: Node, state: ElementStateWithoutStable, frameVisible: boolean): ElementStateQueryResult;
elementState(node: Node, state: Exclude<ElementStateWithoutStable, 'visible' | 'hidden'>): ElementStateQueryResult;
elementState(node: Node, state: ElementStateWithoutStable, frameVisible?: boolean): ElementStateQueryResult {
const element = this.retarget(node, ['visible', 'hidden'].includes(state) ? 'none' : 'follow-label');
if (!element || !element.isConnected) {
if (state === 'hidden')
Expand All @@ -762,7 +764,7 @@ export class InjectedScript {
}

if (state === 'visible' || state === 'hidden') {
const visible = isElementVisible(element);
const visible = !!frameVisible && isElementVisible(element);
return {
matches: state === 'visible' ? visible : !visible,
received: visible ? 'visible' : 'hidden'
Expand Down Expand Up @@ -1464,20 +1466,20 @@ export class InjectedScript {
this.onGlobalListenersRemoved.add(addHitTargetInterceptorListeners);
}

async expect(element: Element, options: FrameExpectParams, elements: Element[]): Promise<{ matches: boolean, received?: ExpectReceived }> {
async expect(element: Element, options: FrameExpectParams, elements: Element[], frameVisible: boolean): Promise<{ matches: boolean, received?: ExpectReceived }> {
const isArray = options.expression === 'to.have.count' || options.expression.endsWith('.array');
const core = isArray ? this.expectArray(elements, options) : await this.expectSingleElement(element, options);
const ariaSnapshot = core.matches !== options.isNot ? undefined : this._ariaSnapshotForExpect(element, options);
const core = isArray ? this.expectArray(elements, options) : await this.expectSingleElement(element, options, frameVisible);
const ariaSnapshot = core.matches !== options.isNot ? undefined : this._ariaSnapshotForExpect(element, options, frameVisible);
if (core.received === undefined && ariaSnapshot === undefined)
return { matches: core.matches };
return { matches: core.matches, received: { value: core.received, ariaSnapshot } };
}

private _ariaSnapshotForExpect(element: Element, options: FrameExpectParams): string | undefined {
private _ariaSnapshotForExpect(element: Element, options: FrameExpectParams, frameVisible: boolean): string | undefined {
const expression = options.expression;
if (expression === 'to.have.count' || expression.endsWith('.array') || expression === 'to.match.aria')
return undefined;
if (isElementVisible(element) && expression !== 'to.have.title' && expression !== 'to.have.url') {
if (frameVisible && isElementVisible(element) && expression !== 'to.have.title' && expression !== 'to.have.url') {
// Element-scoped snapshot. Containment matchers want the full subtree;
// property matchers only need the element's own line.
const isContainment = expression === 'to.have.text';
Expand All @@ -1488,7 +1490,7 @@ export class InjectedScript {
return this.ariaSnapshotForExpectFailure(this.document.body, { mode: 'default' });
}

private async expectSingleElement(element: Element, options: FrameExpectParams): Promise<{ matches: boolean, received?: any }> {
private async expectSingleElement(element: Element, options: FrameExpectParams, frameVisible: boolean): Promise<{ matches: boolean, received?: any }> {
const expression = options.expression;

{
Expand Down Expand Up @@ -1545,9 +1547,9 @@ export class InjectedScript {
received: focused ? 'focused' : 'inactive',
};
} else if (expression === 'to.be.hidden') {
result = this.elementState(element, 'hidden');
result = this.elementState(element, 'hidden', frameVisible);
} else if (expression === 'to.be.visible') {
result = this.elementState(element, 'visible');
result = this.elementState(element, 'visible', frameVisible);
} else if (expression === 'to.be.attached') {
result = {
matches: true,
Expand Down
Loading
Loading