Skip to content

fix(webkit): hide content of a details nested in a closed details #42951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Yuriy Mikityuk (yuriy-mikityuk) wants to merge 1 commit into from
Closed

fix(webkit): hide content of a details nested in a closed details #42951

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions packages/injected/src/domUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,9 +108,12 @@ function computeElementStyleVisibilityVisible(element: Element, style?: CSSStyle
return false;
} else {
// Manual workaround for WebKit that does not have checkVisibility.
const detailsOrSummary = element.closest('details,summary');
if (detailsOrSummary !== element && detailsOrSummary?.nodeName === 'DETAILS' && !(detailsOrSummary as HTMLDetailsElement).open)
return false;
// Check all ancestors: an open details inside a closed one is still hidden.
for (let child: Element | undefined = element; child; child = parentElementOrShadowHost(child)) {
const parent = parentElementOrShadowHost(child);
if (parent?.nodeName === 'DETAILS' && !(parent as HTMLDetailsElement).open && child.nodeName !== 'SUMMARY')
return false;
}
}
if (style.visibility !== 'visible')
return false;
Expand Down
15 changes: 15 additions & 0 deletions tests/page/locator-is-visible.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,21 @@ it('isVisible and isHidden should work with details', async ({ page }) => {
await expect(page.locator('ul')).toBeHidden();
});

it('isVisible and isHidden should work with nested details', async ({ page }) => {
await page.setContent(`<details>
<summary>outer</summary>
<details open>
<summary>inner</summary>
<button>hidden button</button>
</details>
</details>`);

await expect(page.locator('summary', { hasText: 'outer' })).toBeVisible();
await expect(page.locator('summary', { hasText: 'inner' })).toBeHidden();
await expect(page.locator('button')).toBeHidden();
await expect(page.getByRole('button')).toHaveCount(0);
});

it('isVisible inside a button', async ({ page }) => {
await page.setContent(`<button><span></span>a button</button>`);
const span = page.locator('span');
Expand Down