Repository navigation
fix(list reporter): decode multi-byte stdio chunks correctly across writes - #43143
Closed
Suparva (SuparvaCode) wants to merge 1 commit into
Closed
Suparva (SuparvaCode) wants to merge 1 commit into
Suparva (SuparvaCode) wants to merge 1 commit into
Conversation
…rites References microsoft#43079. In microsoft#42886, ListReporter._dumpToStdio decoded stdio chunks with chunk.toString('utf-8'). When multi-byte characters are split across chunk writes from worker processes, decoding chunk-by-chunk corrupted them into replacement characters. Use StringDecoder from string_decoder per worker/stream to buffer incomplete multi-byte sequences across chunk boundaries, ensuring clean line-prefixing and uncorrupted terminal output.
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ListReporter._dumpToStdiodecoded worker stdio chunks directly withchunk.toString('utf-8'). When multi-byte UTF-8 sequences are split across chunk boundaries, chunk-by-chunk string decoding produced replacement characters (\uFFFD).StringDecoderinListReporterso partial multi-byte sequences are buffered until completed before formatting and emitting.onEnd.Fixes #43079