Repository navigation
fix(chromium): fail 204 navigation requests - #43291
Merged
Merged
Conversation
Since #42834, Chromium reported every 204 response as finished, including navigation requests. A 204 navigation never commits, and the frame only drops its pending navigation when the navigation request fails, so a click on a link answered with 204 waited for the navigation until the action timed out. Keep reporting 204 subresources as finished, and fail 204 navigations as Firefox and WebKit do. Fixes: #43279
Contributor
Test results for "tests 1"7 flaky53306 passed, 1266 skipped Merge workflow run. |
Contributor
Test results for "MCP"9165 passed, 1495 skipped Merge workflow run. |
Pavel Feldman (pavelfeldman)
marked this pull request as ready for review
October 12, 2026 17:29
Dmitry Gozman (dgozman)
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #42834, Chromium reported every 204 response as finished, including navigation requests. A 204 navigation never commits, and the frame only drops its pending navigation when the navigation request fails, so
page.click()on a link answered with 204 waited for the navigation until the action timed out (regressed in 1.64).This keeps reporting 204 subresources as finished (#42786) and fails 204 navigations, as Firefox and WebKit already do.
Tests: a click on a 204 link no longer waits, and a 204 navigation request emits
requestfailed. Both fail on Chromium without the fix and pass on all three browsers with it.Fixes: #43279