Skip to content

test: fix user activation file chooser tests on Electron, Android and the frozen clock #43408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Yury Semikhatsky (yury-s) merged 3 commits into from
Oct 15, 2026
Merged

test: fix user activation file chooser tests on Electron, Android and the frozen clock #43408

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
37c280d
test: skip user activation file chooser tests where the engine differs
yury-s Oct 15, 2026
4627e25
test: wait for a console message instead of polling in the activation…
yury-s Oct 15, 2026
5abd4f2
test: clarify the comment about polling and user activation
yury-s Oct 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions tests/page/page-filechooser.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,7 @@ test.describe('user activation', () => {
if (location.search === '?click')
setTimeout(() => input.click(), 0);
if (location.search === '?showPicker')
setTimeout(() => window.showPickerResult = window.showPicker(), 0);
setTimeout(() => console.log('showPicker:' + window.showPicker()), 0);
</script>
`;

Expand All @@ -414,9 +414,11 @@ test.describe('user activation', () => {
await page.waitForTimeout(500);
expect(choosers).toBe(0);

// Do not poll with waitForFunction: each poll evaluates in the page with a user gesture,
// which grants transient user activation and would let showPicker() succeed.
const result = page.waitForEvent('console', msg => msg.text().startsWith('showPicker:'));
await page.goto(server.PREFIX + '/activation.html?showPicker');
await page.waitForFunction(() => !!(window as any).showPickerResult);
expect(await page.evaluate(() => (window as any).showPickerResult)).toBe('NotAllowedError');
expect((await result).text()).toBe('showPicker:NotAllowedError');
expect(choosers).toBe(0);
});

Expand All @@ -439,8 +441,9 @@ test.describe('user activation', () => {
expect(await page.evaluate(() => (window as any).showPicker())).toBe('ok');
});

test('should consume user activation when opening file chooser', async ({ page, server, browserName }) => {
test('should consume user activation when opening file chooser', async ({ page, server, browserName, isElectron, isAndroid }) => {
test.fixme(browserName === 'webkit', 'WebKit does not consume user activation when opening the file chooser');
test.fixme(isElectron || isAndroid, 'Chromium 148 in Electron 42 and Chrome on the Android emulator do not consume user activation');
let choosers = 0;
page.on('filechooser', () => choosers++);
await page.goto(server.PREFIX + '/activation.html');
Expand Down
Loading