Repository navigation
Bound RVM diagnostics without losing HostAwait payloads - #936
Draft
Anand Krishnamoorthi (anakrish) wants to merge 1 commit into
Draft
Anand Krishnamoorthi (anakrish) wants to merge 1 commit into
Anand Krishnamoorthi (anakrish) wants to merge 1 commit into
Conversation
Extract diagnostic safety independently of rule propagation and conflict handling. Related to microsoft#932 and microsoft#934. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4a5b6b76-47ed-4d59-8b05-4cca089961b9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
First independent extraction from #934, based directly on
main. Related to #932; this preparatory PR does not fix or close that issue.This PR contains no rule-error propagation, conflict-detection, comparison-budget, compiler, or bytecode-format changes. #934 remains unchanged.
Changes
Value::diagnostic()for VM errors, execution states, suspension reasons, and the affected aggregate/set/time builtin errors, avoiding expansion of shared values....; bound generic anyhow-to-VM conversion and affected network parse-error messages.Structured Rust values remain intact. Debug text intentionally changes and is not a payload serialization API. These changes cover VM diagnostic formatting and the builtin producers touched here, not every third-party error constructor.
Validation — debug builds only
cargo xtask ci-debug --frozen— passed, including OPA conformance and feature combinations.cargo xtask test-no-std --frozen— passed forthumbv7m-none-eabi.--dev --no-opt, C++ used-O0.cargo xtask fmt --checkandgit diff --check— passed.Builds used at most two Rust jobs. The installed toolchain needs
--force-warn deprecated_in_futurefor two existing Azure builtin deprecations. Strict Clippy also encounters five existing findings in unchanged files (question_mark,for_kv_map, anduseless_borrows_in_formatting); the complete workspace/binding Clippy task is checked with only those categories downgraded to warnings. No repository lint settings are changed.