MLKEM bindings and wrappers - #109
Draft
Khang (nnmkhang) wants to merge 3 commits into
Draft
Conversation
There was a problem hiding this comment.
Pull request overview
Adds ML-KEM support through generated SymCrypt bindings and safe Rust wrappers.
Changes:
- Adds ML-KEM key generation, import/export, encapsulation, decapsulation, and tests.
- Pins SymCrypt v103.6.0 and updates crate versions and bindings.
- Re-enables Windows CI with v103.6.0 binaries.
Reviewed changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
Cargo.toml |
Updates symcrypt-sys; MSRV remains inconsistent. |
Cargo.lock |
Refreshes crate versions. |
.github/workflows/build_windows.yml |
Re-enables Windows builds and tests. |
rust-symcrypt/INSTALL.md |
Points installation guidance to v103.6.0. |
rust-symcrypt/README.md |
Documents ML-KEM and minimum SymCrypt version. |
rust-symcrypt/src/lib.rs |
Exposes the ML-KEM module. |
rust-symcrypt/src/mlkem.rs |
Implements and tests safe ML-KEM wrappers. |
symcrypt-bindgen/Cargo.toml |
Bumps bindgen utility version. |
symcrypt-bindgen/src/main.rs |
Allows ML-KEM symbols during generation. |
symcrypt-sys/Cargo.toml |
Bumps FFI crate version. |
symcrypt-sys/VERSION.md |
Pins the v103.6.0 commit. |
symcrypt-sys/inc/symcrypt_internal_shared.inc |
Updates the SymCrypt API minor version. |
symcrypt-sys/src/bindings/aarch64_pc_windows_msvc.rs |
Adds Windows ARM64 ML-KEM bindings. |
symcrypt-sys/src/bindings/aarch64_unknown_linux_gnu.rs |
Adds Linux ARM64 ML-KEM bindings. |
symcrypt-sys/src/bindings/x86_64_pc_windows_msvc.rs |
Adds Windows x64 ML-KEM bindings. |
symcrypt-sys/src/bindings/x86_64_unknown_linux_gnu.rs |
Adds Linux x64 ML-KEM bindings. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| libc = "0.2.0" | ||
| hex = "0.4.3" | ||
| symcrypt-sys = { path = "symcrypt-sys", version = "0.4.0" } | ||
| symcrypt-sys = { path = "symcrypt-sys", version = "0.5.0" } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes:
Added MLKEM
Breaking Changes if any:
symcrypt-systo0.5.0rust-symcryptfrom to0.6.0MSRVto1.85.✅ Admin Checklist
cargo test --all-featuresonWindowsandWSL.Check the Developer Guidelines in DEVELOPER.md for more info.