Repository navigation
Resolve dependency security alerts - #358
Open
dependabot[bot] wants to merge 4 commits into
Open
dependabot[bot] wants to merge 4 commits into
dependabot[bot] wants to merge 4 commits into
Conversation
Bumps [github.com/go-chi/chi/v5](https://github.com/go-chi/chi) from 5.2.4 to 5.4.0. - [Release notes](https://github.com/go-chi/chi/releases) - [Changelog](https://github.com/go-chi/chi/blob/master/CHANGELOG.md) - [Commits](go-chi/chi@v5.2.4...v5.4.0) --- updated-dependencies: - dependency-name: github.com/go-chi/chi/v5 dependency-version: 5.4.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Migrate to the maintained Docker client and API modules, patch both Vite dependency trees and esbuild, add Docker SDK regression tests, and regenerate notices. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🔵 Needs a closer look
The Docker SDK migration affects installation, upgrades, data migrations, cleanup, and SSH image pulls, but validation used only mocked API responses, leaving live Docker daemon and SSH compatibility unverified.
No open issues 🎉
1 file not reviewed
docs/package-lock.json: Generated file
What changed in this PR
This PR addresses dependency alerts in Tyger’s CLI and documentation tooling, migrates Docker integration to maintained Moby modules, and expands automated dependency updates.
Changes:
- Updates Go and npm dependencies, refreshes lockfiles, and regenerates third-party notices.
- Adapts Docker installer and image-pull calls to the Moby SDK, with regression tests for API compatibility and core operations.
- Adds weekly grouped Dependabot updates for Go, npm, NuGet, and Docker, plus maintenance and compatibility documentation.
| File | Description |
|---|---|
README.md |
Documents dependency updates and notice regeneration. |
NOTICE.txt |
Replaces legacy Docker notices with Moby module licenses. |
docs/README.md |
Explains dependency overrides and validation steps. |
docs/package.json |
Updates Vite and adds scoped security overrides. |
docs/package-lock.json |
Records updated documentation dependencies. |
docs/introduction/installation/docker-installation.md |
Documents the Docker API minimum and daemon update responsibility. |
cli/internal/install/dockerinstall/migrations.go |
Adapts migration operations to the Moby SDK. |
cli/internal/install/dockerinstall/docker.go |
Migrates Docker operations and handles image-pull stream failures. |
cli/internal/install/dockerinstall/docker_test.go |
Adds Docker API negotiation and operation regression tests. |
cli/internal/cmd/run.go |
Migrates run image-pulling calls to the Moby client. |
cli/go.sum |
Refreshes Go dependency checksums. |
cli/go.mod |
Updates chi and replaces the legacy Docker SDK dependencies. |
.notice-metadata.txt |
Refreshes generated notice tracking hashes. |
.github/dependabot.yml |
Expands ecosystem coverage with weekly groups and seven-day cooldowns. |
Review effort: Balanced
Remove the added Go, npm, NuGet, and Docker version-update schedules and the related README section. Preserve the dependency security fixes, regression tests, and generated notices. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps github.com/go-chi/chi/v5 from 5.2.4 to 5.4.0.
Release notes
Sourced from github.com/go-chi/chi/v5's releases.
... (truncated)
Commits
7f9b744middleware: treat RemoteAddr as the rightmost hop in ClientIPFrom* (#1214)167e1e3README: point middleware doc links to chi/v5 (#1196)3d1777amiddleware: honor Discard when flushing (#1185)b1c9ab4middleware: record response status when flushing (#1174)ae6be74Simplify chi.URLParam, call chi.URLParamFromCtx (#1168)50ef4e4Replace "interface{}" with "any" (#1167)77074b3Use slices.Backward where appropriate (#1165)756fcb8Bump minimum Go to 1.24, use b.Loop() (#1164)5ac7a82Remove superfluous import aliases (#1166)36611d2test(middleware): Improves test coverage (#700)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.
Additional security remediation
Expanded this PR to address existing security alerts at the maintainer's request; PR #359 is unchanged.
github.com/docker/dockerdependency with maintainedgithub.com/moby/moby/apiandgithub.com/moby/moby/clientmodules. Updated all installer and image-pull call sites and added regression tests, including negotiation with Engine API 1.41, port bindings, certificate archive uploads, network subnets, wait/log streams, and pull failures.Security verification
Checked every installed copy against the vulnerable ranges from all 15 currently open GitHub Dependabot alerts. No affected versions remain in this PR's edited Go/npm dependency graph. Alerts will remain listed against the default branch until the fixes are merged and GitHub reprocesses dependencies. No alerts were dismissed.
Validation
Passed: full build,
make verify-format, all Go tests, targeted race tests andgo vet, integration-test compilation, cleannpm ci, complete npm dependency-tree validation, documentation production build, browser smoke test of the development server, Dependabot YAML/path checks, and notice regeneration followed by an up-to-date check.Environment limitations: the .NET unit runner timed out connecting to its test host (the pre-existing local issue); live integration tests were not run because no Tyger login/deployment is configured.
npm auditwas blocked by the Microsoft proxy returning HTTP 429; the direct npm registry was also unreachable. The authenticated GitHub advisory-range verification above independently covered all 15 existing repository alerts.Maintenance scope decision
Local read-only Dependabot previews identified substantial version-update work, distinct from the existing security alerts. The additional version-update schedules were therefore reverted rather than starting an ongoing upgrade campaign ahead of repository archival. This does not disable repository security alerts or undo any security fixes. The rollback changes only
.github/dependabot.ymland the related README section; both match their pre-expansion versions exactly.