Skip to content

fix: allow registry-only release recovery - #626

Merged
Mohamed Mansour (mohamedmansour) merged 2 commits into
mainfrom
mohamedmansour-npm-publish-failure
Oct 31, 2026
Merged

Mohamed Mansour (mohamedmansour) merged 2 commits into
mainfrom
mohamedmansour-npm-publish-failure

Conversation

@mohamedmansour

@mohamedmansour Mohamed Mansour (mohamedmansour) commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Add a publishGitHub CD parameter, enabled by default, to skip only the GitHub release job during registry-only recovery.
  • Keep release metadata validation, signing, tag verification, and npm/Rust publishing unchanged.
  • Document selecting the original releaseBuild run in the parameter comment. This PR changes only the CD pipeline YAML; the added Rust test was removed at the maintainer's request.

Validation

  • Azure DevOps preview-only compilation passed for default publication, registry-only recovery, and validation mode. The GitHub job condition is false only in recovery; npm/Rust publication remains enabled. No production run was queued.
  • WEBUI_PRESS_BINARY_PATH="$PWD/target/debug/webui-press" cargo xtask check passed after test removal. The explicit local sidecar avoids an unrelated globally installed Press 0.0.29.
  • The first post-removal gate encountered two unrelated macOS clipboard test failures (Contended and a pasteboard change-count mismatch). An unchanged full-gate retry passed; no clipboard tests were modified or skipped, and this PR does not fix that intermittent failure.

@mddinbox mddinbox left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 50b7e6f; static review of the registry-only release condition; all applicable current-head CI checks passed.

@mohamedmansour
Mohamed Mansour (mohamedmansour) merged commit fd2d752 into main Oct 31, 2026
41 checks passed
@mohamedmansour
Mohamed Mansour (mohamedmansour) deleted the mohamedmansour-npm-publish-failure branch October 31, 2026 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants