Skip to content

Fix Graph request OutputType forwarding and alias handling - #1596

Merged
Anton Staykov (astaykov) merged 2 commits into
devfrom
fix/graph-request-output-type
Oct 19, 2026
Merged

Anton Staykov (astaykov) merged 2 commits into
devfrom
fix/graph-request-output-type

Conversation

@ashwinikarke

Copy link
Copy Markdown
Collaborator

Summary

Addresses the public-wrapper OutputType follow-up from #1584.

  • Forward OutputType to Invoke-ZtGraphBatchRequest.
  • Normalize PSCustomObject to SDK-supported PSObject for individual requests and continuation pages.
  • Update help text and fixed 20-request batching expectations.
  • Add coverage for output representations, paging through the real cache helper, API routing, malformed responses, and retries.

Dependency

Requires #1590 to merge first for the private helper's OutputType support.

@ashwinikarke ashwinikarke self-assigned this Oct 14, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Static review found no blocking issues and confirmed prerequisite helper support is present; tests were not executed.

0 open findings

What changed in this PR

Completes the public Graph request wrapper’s OutputType handling, building on the batch-helper support from #1590.

Changes:

  • Forwards OutputType to batches and normalizes PSCustomObject for individual requests and continuation pages.
  • Updates batching help and expands regression coverage for output types, paging, routing, malformed responses, and retries.
File Description
src/​powershell/​public/​Invoke-ZtGraphRequest.ps1 Forwards OutputType, normalizes its alias, and updates help.
code-tests/​commands/​Invoke-ZtGraphRequest.Tests.ps1 Expands wrapper and real-cache regression coverage.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@ashwinikarke
ashwinikarke marked this pull request as ready for review October 16, 2026 09:19
@ashwinikarke ashwinikarke added the ready for review PR is ready for review and merging label Oct 16, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@astaykov
Anton Staykov (astaykov) merged commit d422ca9 into dev Oct 19, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for review PR is ready for review and merging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants