Target .NET 11 and EF Core 11 preview for an 11.0.0-preview.1 release - #440
Merged
Merged
Conversation
Open
Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update to support .NET 11 in Pomelo.EntityFrameworkCore.MySql
Target .NET 11 and EF Core 11 preview for an 11.0.0-preview.1 release
Sep 7, 2026
bart-vmware
reviewed
Sep 7, 2026
| <PreReleaseVersionIteration></PreReleaseVersionIteration> | ||
| <VersionPrefix>11.0.0</VersionPrefix> | ||
| <PreReleaseVersionLabel>preview</PreReleaseVersionLabel> | ||
| <PreReleaseVersionIteration>1</PreReleaseVersionIteration> |
There was a problem hiding this comment.
I think this should be 7, to align with:
<EFCoreVersion>[11.0.0-preview.7.26381.103,11.0.999]</EFCoreVersion>
Member
There was a problem hiding this comment.
@copilot take this into consideration, so we are inline with the EF Core release numbering for the preview
…firewall Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
…1 model changes Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
…aining MySQL failures Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
…ntax Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
…timizer Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
…sertion Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
… rewrite baselines on both servers Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
…ry point Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
- JsonTypes: convert the two ulong enum theories from `new`/implicit
hiding to real overrides so the inherited InlineData cases (notably
UInt64.MaxValue) are actually suppressed rather than still executed.
The nullable overload's base parameter is `object`, not `EnumU64?`.
- BulkUpdates: skip Update_Where_Skip[_Take]_set_constant, which use
LIMIT/OFFSET without ORDER BY. The latter previously carried an
inverted SupportedServerVersionCondition("0.0.0-mysql") that ran it
only on the server where it is unreliable.
- GroupBy_Select_Anonymous_Type_With_Entire_Entity: skip unconditionally;
it also fails on several MariaDB versions, not just MySQL.
- ToListAsync_can_be_canceled: drop the fixed AssertSql baseline, since
the statement count depends on when cancellation happens.
Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
…e.yml The IntegrationTests project's launchSettings.json sets `commandLineArgs: "testMigrate"`, which is one of the commands its Program.Main recognizes. Under the Microsoft.Testing.Platform runner, `dotnet test` applies the default launch profile, so the test host was started with `testMigrate` and ran the migration routine instead of the MTP server. The runner then reported "Zero tests ran", a handshake failure and exit code 5. pr-build.yml was already fixed; build.yml and release.yml carry the same four integration-test steps and were missed, so pushes to the branch (which run build.yml) still failed. Only the IntegrationTests project has a launchSettings.json, so the functional and unit test steps are unaffected. Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
…robe The baselines have been regenerated and the full matrix is green, so the temporary branch-scoped `push:` trigger has served its purpose. It only produced a failing run on every push, because the readiness probe was broken, and it was always documented as something to remove. The probe used `(mariadb || mysql) --protocol=tcp ...`, which is not a fallback but a shell syntax error: arguments cannot be appended to a `( ... )` compound command, so `sh` exited with 2 on every attempt. The loop therefore always ran its full 300 iterations and reported "Database server failed to start within 5 minutes", even though the server was up. Verified against real mysql:8.0.40 and mariadb:11.8.5 containers: the old probe fails with a syntax error against a ready server, while the new one (two complete commands joined by `||`) succeeds on both, and still returns non-zero while the server is starting so the loop keeps waiting. Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
`cut -d 'v' -f 2` splits the tag on every `v`, not just the leading one, so `v11.0.0-preview.1` yielded `11.0.0-pre`. Strip the `refs/tags/v` prefix instead. Verified across v11.0.0, v11.0.0-preview.1/.10, v11.0.0-rc.1, v10.0.0-beta.2 and a build-metadata tag: only the `preview` tags change, so existing release tags are unaffected. This value feeds `-p:OfficialVersion`, whose purpose is to assert that the git tag matches Version.props. The package version itself comes from Version.props, and the target that compares the two is currently commented out, so this did not mis-version any package: packing with the truncated value still produces 11.0.0-preview.1. It would, however, make that assertion wrong for every future preview tag. Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
renemadsen
marked this pull request as ready for review
September 24, 2026 05:26
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The integration test project has unresolved xUnit v3 runner dependencies, and server-version conditions are not universally skipped.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (2)
What changed in this PR
Targets the provider and test infrastructure at .NET 11 and EF Core 11 preview for the 11.0.0-preview.1 release.
Changes:
- Updates SDK, frameworks, dependencies, tooling, and package metadata.
- Adapts provider mappings, query translation, validation, and migration APIs.
- Migrates tests and CI toward xUnit v3 and Microsoft Testing Platform.
| File | Reviewed change |
|---|---|
Version.props |
Preview release version |
test/Shared/TestUtilities/Attributes/SupportedServerVersionLessThanConditionAttribute.cs |
Server-version condition migration |
test/Shared/TestUtilities/Attributes/SupportedServerVersionConditionAttribute.cs |
Server-version condition migration |
test/Shared/TestUtilities/Attributes/SupportedServerVersionBetweenConditionAttribute.cs |
Server-version condition migration |
test/Shared/TestUtilities/Attributes/MySqlTestTrait.cs |
Trait-based test filtering |
test/EFCore.MySql.Tests/TestBase.cs |
Test lifecycle updates |
test/EFCore.MySql.Tests/Query/MySqlTimeZoneTest.cs |
Query test updates |
test/EFCore.MySql.Tests/Query/MySqlCollationTest.cs |
Query test updates |
test/EFCore.MySql.Tests/MySqlTestFixtureBase.cs |
Fixture lifecycle updates |
test/EFCore.MySql.Tests/MySqlRelationalConnectionTest.cs |
Connection test updates |
test/EFCore.MySql.Tests/MySqlDbContextOptionsExtensionsTest.cs |
Options test updates |
test/EFCore.MySql.Tests/Migrations/MySqlHistoryRepositoryTest.cs |
Migration test updates |
test/EFCore.MySql.Tests/Bugs/MySqlBug96947.cs |
Regression test updates |
test/EFCore.MySql.Tests/Behaviors/SpatialBehavior.cs |
Spatial behavior updates |
test/EFCore.MySql.Tests/Behaviors/MySql8WithSridConstraintSpatialBehavior.cs |
Spatial behavior updates |
test/EFCore.MySql.Tests/Behaviors/MySql8WithoutSridConstraintSpatialBehavior.cs |
Spatial behavior updates |
test/EFCore.MySql.Tests/Behaviors/HavingBehavior.cs |
Behavior test updates |
test/EFCore.MySql.Tests/AssemblyInfo.cs |
Test framework updates |
test/EFCore.MySql.IntegrationTests/Tests/Models/DiscriminatorTest.cs |
Integration test updates |
test/EFCore.MySql.IntegrationTests/scripts/legacy.ps1 |
Test execution updates |
test/EFCore.MySql.FunctionalTests/ValueConvertersEndToEndMySqlTest.cs |
Functional test updates |
test/EFCore.MySql.FunctionalTests/UpdatesMySqlTest.cs |
Functional test updates |
test/EFCore.MySql.FunctionalTests/Update/StoreValueGenerationMySqlTest.cs |
Update test changes |
test/EFCore.MySql.FunctionalTests/Update/StoredProcedureUpdateMySqlTest.cs |
Stored procedure test changes |
test/EFCore.MySql.FunctionalTests/Update/NonSharedModelUpdatesMySqlTest.cs |
Update test changes |
test/EFCore.MySql.FunctionalTests/Update/MySqlUpdateSqlGeneratorTest.cs |
SQL generator test changes |
test/EFCore.MySql.FunctionalTests/TPTTableSplittingMySqlTest.cs |
TPT test updates |
test/EFCore.MySql.FunctionalTests/TestUtilities/Xunit/MySqlXunitTheoryTestCaseRunner.cs |
xUnit infrastructure migration |
test/EFCore.MySql.FunctionalTests/TestUtilities/Xunit/MySqlXunitTestFrameworkExecutor.cs |
xUnit infrastructure migration |
test/EFCore.MySql.FunctionalTests/TestUtilities/Xunit/MySqlXunitTestFramework.cs |
xUnit infrastructure migration |
test/EFCore.MySql.FunctionalTests/TestUtilities/Xunit/MySqlXunitTestCollectionRunner.cs |
xUnit infrastructure migration |
test/EFCore.MySql.FunctionalTests/TestUtilities/Xunit/MySqlXunitTestCaseRunner.cs |
xUnit infrastructure migration |
test/EFCore.MySql.FunctionalTests/TestUtilities/Xunit/MySqlXunitTestAssemblyRunner.cs |
xUnit infrastructure migration |
test/EFCore.MySql.FunctionalTests/TestUtilities/Xunit/MySqlTestCollectionOrderer.cs |
xUnit infrastructure migration |
test/EFCore.MySql.FunctionalTests/TestUtilities/Xunit/MySqlTestCaseOrderer.cs |
xUnit infrastructure migration |
test/EFCore.MySql.FunctionalTests/TestUtilities/Xunit/MySqlConditionalTheoryTestCase.cs |
Conditional test migration |
test/EFCore.MySql.FunctionalTests/TestUtilities/Xunit/MySqlConditionalTheoryDiscoverer.cs |
Conditional test migration |
test/EFCore.MySql.FunctionalTests/TestUtilities/Xunit/MySqlConditionalFactTestCase.cs |
Conditional test migration |
test/EFCore.MySql.FunctionalTests/TestUtilities/Xunit/MySqlConditionalFactDiscoverer.cs |
Conditional test migration |
test/EFCore.MySql.FunctionalTests/TestUtilities/Xunit/IMySqlTestClassOrderer.cs |
xUnit infrastructure migration |
test/EFCore.MySql.FunctionalTests/TestUtilities/MySqlTestStore.cs |
Test store API updates |
test/EFCore.MySql.FunctionalTests/TestUtilities/MySqlDatabaseFacadeTestExtensions.cs |
Database test utility updates |
test/EFCore.MySql.FunctionalTests/TestUtilities/MySqlDatabaseCleaner.cs |
Database cleaner updates |
test/EFCore.MySql.FunctionalTests/TableSplittingMySqlTest.cs |
Table-splitting test updates |
test/EFCore.MySql.FunctionalTests/SpatialMySqlTest.cs |
Spatial test updates |
test/EFCore.MySql.FunctionalTests/ServiceProviderPerContextFixtureBase.cs |
Fixture lifecycle updates |
test/EFCore.MySql.FunctionalTests/Scaffolding/CompiledModelMySqlTest.cs |
Scaffolding test updates |
test/EFCore.MySql.FunctionalTests/Scaffolding/Baselines/Triggers/DbContextModel.cs |
Generated baseline update |
test/EFCore.MySql.FunctionalTests/Scaffolding/Baselines/Triggers/DbContextAssemblyAttributes.cs |
Generated baseline update |
test/EFCore.MySql.FunctionalTests/Scaffolding/Baselines/Triggers/DataUnsafeAccessors.cs |
Generated baseline update |
test/EFCore.MySql.FunctionalTests/Scaffolding/Baselines/Tpc_Sprocs/PrincipalDerivedUnsafeAccessors.cs |
Generated baseline update |
test/EFCore.MySql.FunctionalTests/Scaffolding/Baselines/Tpc_Sprocs/DependentBaseUnsafeAccessors.cs |
Generated baseline update |
test/EFCore.MySql.FunctionalTests/Scaffolding/Baselines/Tpc_Sprocs/DbContextModel.cs |
Generated baseline update |
test/EFCore.MySql.FunctionalTests/Scaffolding/Baselines/Tpc_Sprocs/DbContextAssemblyAttributes.cs |
Generated baseline update |
test/EFCore.MySql.FunctionalTests/Scaffolding/Baselines/SimpleModel/DependentDerivedUnsafeAccessors.cs |
Generated baseline update |
test/EFCore.MySql.FunctionalTests/Scaffolding/Baselines/SimpleModel/DependentBaseUnsafeAccessors.cs |
Generated baseline update |
test/EFCore.MySql.FunctionalTests/Scaffolding/Baselines/SimpleModel/DbContextModel.cs |
Generated baseline update |
test/EFCore.MySql.FunctionalTests/Scaffolding/Baselines/SimpleModel/DbContextAssemblyAttributes.cs |
Generated baseline update |
test/EFCore.MySql.FunctionalTests/Scaffolding/Baselines/Sequences/DbContextModelBuilder.cs |
Generated baseline update |
test/EFCore.MySql.FunctionalTests/Scaffolding/Baselines/Sequences/DbContextModel.cs |
Generated baseline update |
test/EFCore.MySql.FunctionalTests/Scaffolding/Baselines/Sequences/DbContextAssemblyAttributes.cs |
Generated baseline update |
test/EFCore.MySql.FunctionalTests/Scaffolding/Baselines/Owned_entity_sharing_table_with_owner_that_has_an_index/PostUnsafeAccessors.cs |
Generated baseline update |
test/EFCore.MySql.FunctionalTests/Scaffolding/Baselines/Owned_entity_sharing_table_with_owner_that_has_an_index/DbContextModel.cs |
Generated baseline update |
test/EFCore.MySql.FunctionalTests/Scaffolding/Baselines/Owned_entity_sharing_table_with_owner_that_has_an_index/DbContextAssemblyAttributes.cs |
Generated baseline update |
test/EFCore.MySql.FunctionalTests/Scaffolding/Baselines/Owned_entity_sharing_table_with_owner_that_has_an_index/BlogUnsafeAccessors.cs |
Generated baseline update |
test/EFCore.MySql.FunctionalTests/Scaffolding/Baselines/Owned_entity_sharing_table_with_owner_that_has_an_index/AuthorUnsafeAccessors.cs |
Generated baseline update |
test/EFCore.MySql.FunctionalTests/Scaffolding/Baselines/No_NativeAOT/DbContextModel.cs |
Generated baseline update |
test/EFCore.MySql.FunctionalTests/Scaffolding/Baselines/No_NativeAOT/DbContextAssemblyAttributes.cs |
Generated baseline update |
test/EFCore.MySql.FunctionalTests/Scaffolding/Baselines/Dynamic_schema/DbContextModel.cs |
Generated baseline update |
test/EFCore.MySql.FunctionalTests/Scaffolding/Baselines/Dynamic_schema/DbContextAssemblyAttributes.cs |
Generated baseline update |
test/EFCore.MySql.FunctionalTests/Scaffolding/Baselines/Dynamic_schema/DataUnsafeAccessors.cs |
Generated baseline update |
test/EFCore.MySql.FunctionalTests/Scaffolding/Baselines/DbFunctions/DbFunctionContextModel.cs |
Generated baseline update |
test/EFCore.MySql.FunctionalTests/Scaffolding/Baselines/DbFunctions/DbFunctionContextAssemblyAttributes.cs |
Generated baseline update |
test/EFCore.MySql.FunctionalTests/Scaffolding/Baselines/DbFunctions/DataUnsafeAccessors.cs |
Generated baseline update |
test/EFCore.MySql.FunctionalTests/Scaffolding/Baselines/Custom_function_type_mapping/FunctionTypeMappingContextModel.cs |
Generated baseline update |
test/EFCore.MySql.FunctionalTests/Scaffolding/Baselines/Custom_function_type_mapping/FunctionTypeMappingContextAssemblyAttributes.cs |
Generated baseline update |
test/EFCore.MySql.FunctionalTests/Scaffolding/Baselines/Custom_function_parameter_type_mapping/FunctionParameterTypeMappingContextModel.cs |
Generated baseline update |
test/EFCore.MySql.FunctionalTests/Scaffolding/Baselines/Custom_function_parameter_type_mapping/FunctionParameterTypeMappingContextAssemblyAttributes.cs |
Generated baseline update |
test/EFCore.MySql.FunctionalTests/Scaffolding/Baselines/CheckConstraints/DbContextModel.cs |
Generated baseline update |
test/EFCore.MySql.FunctionalTests/Scaffolding/Baselines/CheckConstraints/DbContextAssemblyAttributes.cs |
Generated baseline update |
test/EFCore.MySql.FunctionalTests/Scaffolding/Baselines/CheckConstraints/DataUnsafeAccessors.cs |
Generated baseline update |
test/EFCore.MySql.FunctionalTests/Scaffolding/Baselines/BigModel/PrincipalDerivedUnsafeAccessors.cs |
Generated baseline update |
test/EFCore.MySql.FunctionalTests/Scaffolding/Baselines/BigModel/DependentDerivedUnsafeAccessors.cs |
Generated baseline update |
test/EFCore.MySql.FunctionalTests/Scaffolding/Baselines/BigModel/DependentBaseUnsafeAccessors.cs |
Generated baseline update |
test/EFCore.MySql.FunctionalTests/Scaffolding/Baselines/BigModel/DbContextModel.cs |
Generated baseline update |
test/EFCore.MySql.FunctionalTests/Scaffolding/Baselines/BigModel/DbContextAssemblyAttributes.cs |
Generated baseline update |
test/EFCore.MySql.FunctionalTests/Scaffolding/Baselines/BigModel/DataUnsafeAccessors.cs |
Generated baseline update |
test/EFCore.MySql.FunctionalTests/Scaffolding/Baselines/BigModel_with_JSON_columns/PrincipalDerivedUnsafeAccessors.cs |
Generated baseline update |
test/EFCore.MySql.FunctionalTests/Scaffolding/Baselines/BigModel_with_JSON_columns/DependentDerivedUnsafeAccessors.cs |
Generated baseline update |
test/EFCore.MySql.FunctionalTests/Scaffolding/Baselines/BigModel_with_JSON_columns/DependentBaseUnsafeAccessors.cs |
Generated baseline update |
test/EFCore.MySql.FunctionalTests/Scaffolding/Baselines/BigModel_with_JSON_columns/DbContextModel.cs |
Generated baseline update |
test/EFCore.MySql.FunctionalTests/Scaffolding/Baselines/BigModel_with_JSON_columns/DbContextAssemblyAttributes.cs |
Generated baseline update |
test/EFCore.MySql.FunctionalTests/Scaffolding/Baselines/BigModel_with_JSON_columns/DataUnsafeAccessors.cs |
Generated baseline update |
test/EFCore.MySql.FunctionalTests/Query/TPTRelationshipsQueryMySqlTest.cs |
Query test updates |
test/EFCore.MySql.FunctionalTests/Query/TPTManyToManyQueryMySqlTest.cs |
Query test updates |
test/EFCore.MySql.FunctionalTests/Query/TPTManyToManyQueryMySqlFixture.cs |
Query fixture updates |
test/EFCore.MySql.FunctionalTests/Query/TPTManyToManyNoTrackingQueryMySqlTest.cs |
Query test updates |
test/EFCore.MySql.FunctionalTests/Query/TPTInheritanceQueryMySqlTest.cs |
Query test updates |
test/EFCore.MySql.FunctionalTests/Query/TPTInheritanceQueryMySqlFixture.cs |
Query fixture updates |
test/EFCore.MySql.FunctionalTests/Query/TPTGearsOfWarQueryMySqlFixture.cs |
Query fixture updates |
test/EFCore.MySql.FunctionalTests/Query/TPTFiltersInheritanceQueryMySqlTest.cs |
Query test updates |
test/EFCore.MySql.FunctionalTests/Query/TPHInheritanceQueryMySqlTest.cs |
Query test updates |
test/EFCore.MySql.FunctionalTests/Query/TPHInheritanceQueryMySqlFixture.cs |
Query fixture updates |
test/EFCore.MySql.FunctionalTests/Query/TPCManyToManyQueryMySqlFixture.cs |
Query fixture updates |
test/EFCore.MySql.FunctionalTests/Query/TPCInheritanceQueryMySqlTest.cs |
Query test updates |
test/EFCore.MySql.FunctionalTests/Query/TPCInheritanceQueryMySqlFixture.cs |
Query fixture updates |
test/EFCore.MySql.FunctionalTests/Query/TPCGearsOfWarQueryMySqlFixture.cs |
Query fixture updates |
test/EFCore.MySql.FunctionalTests/Query/TPCFiltersInheritanceQueryMySqlTest.cs |
Query test updates |
test/EFCore.MySql.FunctionalTests/Query/ToSqlQueryMySqlTest.cs |
SQL query test updates |
test/EFCore.MySql.FunctionalTests/Query/SqlQueryMySqlTest.cs |
SQL query test updates |
test/EFCore.MySql.FunctionalTests/Query/SqlExecutorMySqlTest.cs |
SQL executor updates |
test/EFCore.MySql.FunctionalTests/Query/SpatialQueryMySqlTest.cs |
Spatial query updates |
test/EFCore.MySql.FunctionalTests/Query/SharedTypeQueryMySqlTest.cs |
Query test updates |
test/EFCore.MySql.FunctionalTests/Query/QueryNoClientEvalMySqlTest.cs |
Query test updates |
test/EFCore.MySql.FunctionalTests/Query/QueryNavigationsMySqlTest.cs |
Query test updates |
test/EFCore.MySql.FunctionalTests/Query/QueryFilterFuncletizationMySqlTest.cs |
Query test updates |
test/EFCore.MySql.FunctionalTests/Query/OwnedQueryMySqlTest.cs |
Query test updates |
test/EFCore.MySql.FunctionalTests/Query/OwnedEntityQueryMySqlTest.cs |
Query test updates |
test/EFCore.MySql.FunctionalTests/Query/OptionalDependentQueryMySqlTest.cs |
Query test updates |
test/EFCore.MySql.FunctionalTests/Query/OperatorsQueryMySqlTest.cs |
Query test updates |
test/EFCore.MySql.FunctionalTests/Query/OperatorsProceduralMySqlTest.cs |
Query test updates |
test/EFCore.MySql.FunctionalTests/Query/NullSemanticsQueryMySqlTest.cs |
Query test updates |
test/EFCore.MySql.FunctionalTests/Query/NorthwindSqlQueryMySqlTest.cs |
Query test updates |
test/EFCore.MySql.FunctionalTests/Query/NorthwindSplitIncludeQueryMySqlTest.cs |
Query test updates |
test/EFCore.MySql.FunctionalTests/Query/NorthwindSplitIncludeNoTrackingQueryMySqlTest.cs |
Query test updates |
test/EFCore.MySql.FunctionalTests/Query/NorthwindSetOperationsQueryMySqlTest.cs |
Query test updates |
test/EFCore.MySql.FunctionalTests/Query/NorthwindSelectQueryMySqlTest.MySql.cs |
Query test updates |
test/EFCore.MySql.FunctionalTests/Query/NorthwindQueryFiltersQueryMySqlTest.cs |
Query test updates |
test/EFCore.MySql.FunctionalTests/Query/NorthwindMiscellaneousQueryMySqlTest.MySql.cs |
Query test updates |
test/EFCore.MySql.FunctionalTests/Query/NorthwindKeylessEntitiesQueryMySqlTest.cs |
Query test updates |
test/EFCore.MySql.FunctionalTests/Query/NorthwindJoinQueryMySqlTest.cs |
Query test updates |
test/EFCore.MySql.FunctionalTests/Query/NorthwindIncludeQueryMySqlTest.cs |
Query test updates |
test/EFCore.MySql.FunctionalTests/Query/NorthwindFunctionsQueryMySqlTest.MySql.cs |
Query test updates |
test/EFCore.MySql.FunctionalTests/Query/NorthwindFunctionsQueryMySqlTest.cs |
Query test updates |
test/EFCore.MySql.FunctionalTests/Query/NorthwindDbFunctionsQueryMySqlTest.cs |
Query test updates |
test/EFCore.MySql.FunctionalTests/Query/NorthwindCompiledQueryMySqlTest.cs |
Query test updates |
test/EFCore.MySql.FunctionalTests/Query/NorthwindAsNoTrackingQueryMySqlTest.cs |
Query test updates |
test/EFCore.MySql.FunctionalTests/Query/NorthwindAggregateOperatorsQueryMySqlTest.cs |
Query test updates |
test/EFCore.MySql.FunctionalTests/Query/MappingQueryMySqlTest.cs |
Query test updates |
test/EFCore.MySql.FunctionalTests/Query/ManyToManyQueryMySqlTest.cs |
Query test updates |
test/EFCore.MySql.FunctionalTests/Query/ManyToManyNoTrackingQueryMySqlTest.cs |
Query test updates |
test/EFCore.MySql.FunctionalTests/Query/JsonPocoQueryTestBase.cs |
JSON query updates |
test/EFCore.MySql.FunctionalTests/Query/JsonNewtonsoftStringQueryTest.cs |
JSON query updates |
test/EFCore.MySql.FunctionalTests/Query/JsonNewtonsoftStringChangeTrackingTest.cs |
JSON tracking updates |
test/EFCore.MySql.FunctionalTests/Query/JsonNewtonsoftPocoQueryTest.cs |
JSON query updates |
test/EFCore.MySql.FunctionalTests/Query/JsonNewtonsoftPocoChangeTrackingTest.cs |
JSON tracking updates |
test/EFCore.MySql.FunctionalTests/Query/JsonNewtonsoftDomQueryTest.cs |
JSON query updates |
test/EFCore.MySql.FunctionalTests/Query/JsonMicrosoftStringQueryTest.cs |
JSON query updates |
test/EFCore.MySql.FunctionalTests/Query/JsonMicrosoftStringChangeTrackingTest.cs |
JSON tracking updates |
test/EFCore.MySql.FunctionalTests/Query/JsonMicrosoftPocoQueryTest.cs |
JSON query updates |
test/EFCore.MySql.FunctionalTests/Query/JsonMicrosoftPocoChangeTrackingTest.cs |
JSON tracking updates |
test/EFCore.MySql.FunctionalTests/Query/JsonMicrosoftDomQueryTest.cs |
JSON query updates |
test/EFCore.MySql.FunctionalTests/Query/GearsOfWarQueryMySqlTest.cs |
Query test updates |
test/EFCore.MySql.FunctionalTests/Query/FromSqlSprocQueryMySqlTest.cs |
SQL query updates |
test/EFCore.MySql.FunctionalTests/Query/EscapesMySqlTestBase.cs |
Query test updates |
test/EFCore.MySql.FunctionalTests/Query/EscapesMySqlTest.cs |
Query test updates |
test/EFCore.MySql.FunctionalTests/Query/EscapesMySqlNoBackslashesTest.cs |
Query test updates |
test/EFCore.MySql.FunctionalTests/Query/CompositeKeysSplitQueryMySqlTest.cs |
Query test updates |
test/EFCore.MySql.FunctionalTests/Query/CompositeKeysQueryMySqlTest.cs |
Query test updates |
test/EFCore.MySql.FunctionalTests/Query/ComplexNavigationsQueryMySqlTest.cs |
Query test updates |
test/EFCore.MySql.FunctionalTests/Query/ComplexNavigationsCollectionsSplitSharedTypeQueryMySqlTest.cs |
Query test updates |
test/EFCore.MySql.FunctionalTests/Query/BoolIndexingOptimizationDisabledMySqlTest.cs |
Query test updates |
test/EFCore.MySql.FunctionalTests/Query/Associations/ComplexJson/ComplexJsonSetOperationsMySqlTest.cs |
JSON query updates |
test/EFCore.MySql.FunctionalTests/Query/Associations/ComplexJson/ComplexJsonPrimitiveCollectionMySqlTest.cs |
JSON query updates |
test/EFCore.MySql.FunctionalTests/Query/Associations/ComplexJson/ComplexJsonMiscellaneousMySqlTest.cs |
JSON query updates |
test/EFCore.MySql.FunctionalTests/Query/AdHocQuerySplittingQueryMySqlTest.cs |
Query test updates |
test/EFCore.MySql.FunctionalTests/Query/AdHocQueryFiltersQueryMySqlTest.cs |
Query test updates |
test/EFCore.MySql.FunctionalTests/Query/AdHocNavigationsQueryMySqlTest.cs |
Query test updates |
test/EFCore.MySql.FunctionalTests/Query/AdHocManyToManyQueryMySqlTest.cs |
Query test updates |
test/EFCore.MySql.FunctionalTests/Query/AdHocAdvancedMappingsQueryMySqlTest.cs |
Query test updates |
test/EFCore.MySql.FunctionalTests/OptimisticConcurrencyMySqlTest.cs |
Functional test updates |
test/EFCore.MySql.FunctionalTests/NorthwindQueryTaggingQueryMySqlTest.cs |
Functional test updates |
test/EFCore.MySql.FunctionalTests/MySqlComplianceTest.cs |
Compliance test updates |
test/EFCore.MySql.FunctionalTests/MigrationSqlGeneratorMySqlTest.MySql.cs |
Migration test updates |
test/EFCore.MySql.FunctionalTests/MigrationsInfrastructureMySqlTest.cs |
Migration test updates |
test/EFCore.MySql.FunctionalTests/MaterializationInterceptionMySqlTest.cs |
Functional test updates |
test/EFCore.MySql.FunctionalTests/GraphUpdatesMySqlClientNoActionTest.cs |
Graph update test changes |
test/EFCore.MySql.FunctionalTests/GraphUpdatesMySqlClientCascadeTest.cs |
Graph update test changes |
test/EFCore.MySql.FunctionalTests/FullMigrationsMySqlTest.cs |
Migration test updates |
test/EFCore.MySql.FunctionalTests/ExistingConnectionMySqlTest.cs |
Connection test updates |
test/EFCore.MySql.FunctionalTests/EntitySplittingMySqlTest.cs |
Functional test updates |
test/EFCore.MySql.FunctionalTests/DataAnnotationMySqlTest.cs |
Functional test updates |
test/EFCore.MySql.FunctionalTests/ConnectionSettingsMySqlTest.cs |
Connection test updates |
test/EFCore.MySql.FunctionalTests/ConnectionMySqlTest.cs |
Connection test updates |
test/EFCore.MySql.FunctionalTests/ComplexTypesTrackingMySqlTest.cs |
Functional test updates |
test/EFCore.MySql.FunctionalTests/ComplexCollectionJsonMySqlTest.cs |
JSON test updates |
test/EFCore.MySql.FunctionalTests/BulkUpdates/TPTInheritanceBulkUpdatesMySqlTest.cs |
Bulk update test changes |
test/EFCore.MySql.FunctionalTests/BulkUpdates/TPTInheritanceBulkUpdatesMySqlFixture.cs |
Bulk update fixture changes |
test/EFCore.MySql.FunctionalTests/BulkUpdates/TPTFiltersInheritanceBulkUpdatesMySqlTest.cs |
Bulk update test changes |
test/EFCore.MySql.FunctionalTests/BulkUpdates/TPHInheritanceBulkUpdatesMySqlTest.cs |
Bulk update test changes |
test/EFCore.MySql.FunctionalTests/BulkUpdates/TPHInheritanceBulkUpdatesMySqlFixture.cs |
Bulk update fixture changes |
test/EFCore.MySql.FunctionalTests/BulkUpdates/TPHFiltersInheritanceBulkUpdatesMySqlTest.cs |
Bulk update test changes |
test/EFCore.MySql.FunctionalTests/BulkUpdates/TPCInheritanceBulkUpdatesMySqlFixture.cs |
Bulk update fixture changes |
test/EFCore.MySql.FunctionalTests/BulkUpdates/TPCFiltersInheritanceBulkUpdatesMySqlTest.cs |
Bulk update test changes |
test/EFCore.MySql.FunctionalTests/BulkUpdates/NonSharedModelBulkUpdatesMySqlTest.cs |
Bulk update test changes |
test/EFCore.MySql.FunctionalTests/AssemblyInfo.cs |
Test framework updates |
test/Directory.Build.props |
xUnit v3 package migration |
src/EFCore.MySql/Storage/Internal/MySqlTypeMappingSource.cs |
Type mapping updates |
src/EFCore.MySql/Storage/Internal/MySqlTimeOnlyTypeMapping.cs |
Time mapping updates |
src/EFCore.MySql/Storage/Internal/MySqlTimeAsTimeSpanTypeMapping.cs |
Time mapping updates |
src/EFCore.MySql/Storage/Internal/MySqlStructuralJsonTypeMapping.cs |
Structural JSON mapping |
src/EFCore.MySql/Storage/Internal/MySqlDateOnlyTypeMapping.cs |
Date mapping updates |
src/EFCore.MySql/Storage/Internal/MySqlDateAsDateTimeTypeMapping.cs |
Date mapping updates |
src/EFCore.MySql/Query/Internal/MySqlQueryableMethodTranslatingExpressionVisitor.cs |
Query translation updates |
src/EFCore.MySql/Query/ExpressionVisitors/Internal/MySqlQueryTranslationPostprocessor.cs |
Query postprocessing updates |
src/EFCore.MySql/Query/ExpressionVisitors/Internal/MySqlCompatibilityExpressionVisitor.cs |
Compatibility handling |
src/EFCore.MySql/Query/ExpressionTranslators/Internal/MySqlJsonTableExpression.cs |
JSON table expression updates |
src/EFCore.MySql/Migrations/Internal/MySqlHistoryRepository.cs |
History repository API update |
src/EFCore.MySql/Internal/MySqlModelValidator.cs |
Model validation updates |
src/EFCore.MySql/Extensions/MySqlDbContextOptionsBuilderExtensions.cs |
Options default updates |
src/EFCore.MySql/Design/Internal/MySqlCSharpRuntimeAnnotationCodeGenerator.cs |
Design-time API update |
src/EFCore.MySql.NTS/Query/Internal/MySqlGeometryMemberTranslator.cs |
Spatial translation updates |
samples/PassKeyTest/PassKeyTest.csproj |
.NET 11 retargeting |
README.md |
Compatibility documentation |
NuGet.config |
Package source mapping |
global.json |
SDK version update |
dotnet-tools.json |
EF tooling update |
Directory.Build.props |
Framework retargeting |
benchmark/EFCore.MySql.Benchmarks/EFCore.MySql.Benchmarks.csproj |
.NET 11 retargeting |
.github/workflows/pr-build.yml |
CI command updates |
.github/workflows/copilot-setup-steps.yml |
Build setup updates |
.github/workflows/build.yml |
CI command updates |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
| <PackageReference Include="xunit.assert" /> | ||
| <PackageReference Include="xunit.v3.core" /> | ||
| <PackageReference Include="xunit.v3.assert" /> | ||
| <PackageReference Include="xunit.runner.visualstudio" /> |
Comment on lines
+31
to
+38
| /// <summary> | ||
| /// Returns the `category=failing` trait when <paramref name="isMet"/> is `false`, so the runner filters the test | ||
| /// out, and no traits at all when the condition is met. | ||
| /// </summary> | ||
| public static IReadOnlyCollection<KeyValuePair<string, string>> ForCondition(bool isMet) | ||
| => isMet | ||
| ? [] | ||
| : _failing; |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Tracks .NET 11 support: brings the branch in line with master and retargets everything to .NET 11 / EF Core 11 preview so an
11.0.0-preview.1package can be published (npgsql/efcore.pg preview releases used as reference).Build & dependencies
global.json: SDK11.0.100-preview.7.26381.103,allowPrerelease: trueDirectory.Build.props: all target frameworks →net11.0(MySqlConnector.DependencyInjectionstaysnet8.0); benchmark and sample projects retargetedDirectory.Packages.props: EF Core range[11.0.0-preview.7.26381.103,11.0.999], Microsoft.Extensions / ASP.NET Core / BCL packages →11.0.0-preview.7.26381.103, Roslyn packages →5.3.0(required byMicrosoft.EntityFrameworkCore.Design11)NuGet.config: source mapping forMicrosoft.DotNet.XUnitV3Extensions, which EF Core 11's specification-test package pulls in and is only published on thedotnet-engfeedVersion.props→11.0.0-preview.1;dotnet-tools.json→dotnet-ef11.0.0-preview.7Provider changes for EF Core 11 API breaks
MySqlModelValidator:ValidateStoredProceduresis now invoked per entity type;ValidateJsonEntitieswas removed upstream (the override was a pass-through)MySqlHistoryRepository:HistoryRepository.EnsureModelis nowprotected virtual, so the custom implementation overrides it instead of shadowing it — the workaround region can eventually be reduced furtherMySqlStructuralJsonTypeMapping:JsonTypeMappingis obsolete/emptied; base changed toStructuralJsonTypeMappingMySqlJsonTableExpression/MySqlQueryableMethodTranslatingExpressionVisitor:TableValuedFunctionExpression.ArgumentsandUpdatenow useExpressionrather thanSqlExpressionMySqlBoolOptimizingExpressionVisitor:SqlExpressionVisitorwas removed, so it derives fromExpressionVisitorand dispatches the SQL node types itself:Docs
11.0.0-preview.1rowKnown gap
The test projects are not migrated to xUnit v3, which EF Core 11's specification-test assemblies now require (
xunit.v3packages,Microsoft.Testing.Platform,[ConditionalFact]→[Fact]). That migration is sizeable and could not be attempted here — the sandbox cannot reach thedotnet-engpackage CDN, so the test projects don't even restore. Verification was limited to building/packingsrc,benchmark,samples,toolsand exercising the provider against MySQL 8.0.40 (create/insert/query,ExecuteUpdate, owned-entity and complex-collectionToJson, history repository script generation).