Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Exact pnpm pin —
package.jsondevEngines.packageManager.versionmoves from the^12.4.1range to the exact12.4.2, so Corepack resolves a fixed release instead of the newest matching 12.x. - Lockfile refresh —
pnpm-lock.yamlpackageManagerDependencies.pnpmnow recordsspecifier/version12.4.2, with everypnpm@/@pnpm/exe.*@entry and its integrity hash bumped accordingly.
Verified on 16bc7ae: CI=true pnpm install --frozen-lockfile reports "Lockfile is up to date, resolution step is skipped" and exits 0 on pnpm 12.4.2 with a clean tree, all 15 pnpm/exe integrity hashes match registry.npmjs.org, and both Corepack and pnpm/action-setup@v6 consume devEngines.packageManager as the PR describes. The exact pin is the documented Corepack remedy for range drift, and the trade-off (manual, explicit upgrades) is called out in the PR description.
DeepSeek Flash (default — pick a model for stronger reviews) | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Pins pnpm to exactly 12.4.2 in
devEngines.packageManagerinstead of the^12.4.1range, and records 12.4.2 inpnpm-lock.yaml, the same change as middleapi/orpc#2036. With a range, Corepack 0.36.0+ resolves the newest pnpm on npm, and pnpm does not switch to the lockfile's version when Corepack starts it, so every new 12.x release madepnpm install --frozen-lockfilefail withERR_PNPM_FROZEN_LOCKFILE_WITH_OUTDATED_LOCKFILEuntil the lockfile was refreshed.Behavior
devEngines.packageManager.version, then runpnpm install --lockfile-only.packageManagerDependenciesblock and thepnpm/@pnpm/exe.*entries.Testing
CI=trueand cold caches,pnpm install --frozen-lockfilefails onmainwithERR_PNPM_FROZEN_LOCKFILE_WITH_OUTDATED_LOCKFILEand passes on this branch with pnpm 12.4.2.eslint package.jsonpasses.