Skip to content

chore: remove --max-warnings=0 from eslint commands - #8

Merged
dinwwwh merged 1 commit into
mainfrom
claude/quirky-davinci-e177d1
Sep 6, 2026
Merged

chore: remove --max-warnings=0 from eslint commands#8
dinwwwh merged 1 commit into
mainfrom
claude/quirky-davinci-e177d1

Conversation

@dinwwwh

@dinwwwh dinwwwh commented Sep 6, 2026

Copy link
Copy Markdown
Member

Drops --max-warnings=0 from every eslint invocation so lint warnings no longer fail the check; only errors do.

Applies to the lint, lint:fix, and sync:sponsors scripts, the lint-staged pre-commit command, and the Claude Code post-edit hook. Same change is being applied to middleapi/orpc and middleapi/standardserver.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

  • package.json — dropped --max-warnings=0 from lint, lint:fix, and sync:sponsors, and from the lint-staged * entry. Warnings no longer fail these commands; only errors do.
  • .claude/settings.json — dropped --max-warnings=0 from the PostToolUse eslint --fix hook, matching the package scripts.

I verified the sweep is complete on both sides of the diff: the base had exactly five --max-warnings=0 invocations (the four in package.json plus the Claude hook), all five are covered here, and the head tree has no remaining occurrences anywhere (including .zed/settings.json, dependabot.yml, and docs). CI (ci.yaml runs pnpm run lint) and the sponsors sync workflow are consistent with the new behavior, and eslint.config.js sets no warning thresholds that would conflict. The change is mechanical, internally consistent, and matches the stated intent — one deliberate trade-off to note is that warnings can now accumulate silently without an alternative gate, which is the point of the change.

Pullfrog  | View workflow run | Using DeepSeek Flash (default — pick a model for stronger reviews) | 𝕏

@dinwwwh
dinwwwh merged commit 108bb75 into main Sep 6, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant