docs(effect): fix direct-call error-handling example to use safe() - #1997
Closed
Mnigos wants to merge 1 commit into
Closed
docs(effect): fix direct-call error-handling example to use safe()#1997Mnigos wants to merge 1 commit into
Mnigos wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Effect docs: fix direct-call error-handling example — In
apps/content/docs/integrations/effect.mdx, changedconst [error, result] = await call(procedure)toconst [error, data] = await safe(call(procedure)). This is correct:callreturns the output directly (or throws), so the old tuple destructuring could never yield an error forisInferableError; wrapping withsafereturns[error, data], matching the established idiom in the tanstack-query and pinia-colada docs.
DeepSeek Flash (free via Pullfrog for OSS) | 𝕏
Contributor
Author
|
Superseded by #1987, which rewrote this example and already uses |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The "Typesafe Errors" example in the Effect integration guide destructures the result of
call(procedure)as a tuple:callreturns the output directly (or throws), so as written the error path never reachesisInferableErrorand the success path destructures the string'Success'. Switched toawait safe(call(procedure)), matching thesafeidiom used elsewhere in the docs.