chore: remove --max-warnings=0 from eslint commands - #87
Conversation
@standardserver/aws-lambda
@standardserver/core
@standardserver/fastify
@standardserver/fetch
@standardserver/node
@standardserver/peer
@standardserver/shared
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Relax lint gating to errors only — drops
--max-warnings=0from all four eslint invocation sites inpackage.json(lint,lint:fix,sponsors:sync, and the lint-staged pre-commit command), so warnings no longer fail the check.
The removal is complete and consistent: a repo-wide search finds no remaining --max-warnings=0 and no other eslint invocations (sub-package manifests have no lint scripts; dependabot.yml only groups the package names). CI's lint_and_typecheck job runs pnpm run lint, so this relaxes the CI gate from "errors or warnings fail" to "errors fail" — exactly the documented intent of the chore, matching the parallel org-wide change. Nothing blocking.
DeepSeek Flash (default — pick a model for stronger reviews) | 𝕏
Merging this PR will not alter performance
Comparing Footnotes
|

Drops
--max-warnings=0from every eslint invocation so lint warnings no longer fail the check; only errors do.Applies to the
lint,lint:fix, andsponsors:syncscripts and the lint-staged pre-commit command. Same change is being applied to middleapi/openapi-spec and middleapi/orpc.