Repository navigation
feat(sdlc): approve with short issue comments and reopen the web monitor - #40
Merged
Merged
Conversation
mingchuno
force-pushed
the
user-frictions-2-approval
branch
from
October 22, 2026 09:01
84393f0 to
585ef6b
Compare
mingchuno
force-pushed
the
user-frictions-2-approval
branch
from
October 22, 2026 09:14
585ef6b to
a7a4177
Compare
mingchuno
added this pull request to stack #42
October 22, 2026 09:37
- provider approval accepts `/approve GATE CODE`, where CODE names the gate's contract content printed in the published issue section; it counts only while the issue shows the current contract and after the Work Item last changed (ADR 0013); the long form still works - inspections expose approvalComment, shown by start-work, the TUI and the web monitor - run keeps the web monitor link in its control record, falls back to a free port when the default is taken, and `monitor --web [WORK_ID]` reopens it - `#work=ID` links open the web monitor at a Work Item; work commands and doctor return token-free monitorUrl links Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mingchuno
force-pushed
the
user-frictions-2-approval
branch
from
October 22, 2026 09:40
a7a4177 to
ab3182f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 2 of 3 (stacked on #39). Approving work no longer needs the CLI or a 100-character string.
Summary
Provider approval (D1).
The code is the first 12 hex characters of the gate's contract digest, computed without
sourceRevision. That is what lets the published section print it; the full revision covers the issue body, so the body can't contain it (ADR 0011).syncWorkApprovalsaccepts the short form only when all of these hold (ADR 0013):The long form is still accepted. The published section ends with an Approval block giving the exact comment per gate, or "Approve in the agent-workflows monitor" for
local-operator.WorkInspection.approvalCommentcarries it towork inspect, the TUI and the web monitor.Getting back to the web monitor.
The web app opens
#work=IDdirectly in the Work Items view. An explicit--web-portstill fails rather than moving to another port.Skill.
delegated.mdnow tells the human in one line where to approve: the issue comment, the monitor link, ormonitor --web WORK_ID.Evidence
tests/work-publication.test.ts:sourceRevisionand changes when the content changesreadytests/web.test.ts: with 8787 taken,runmoves to a free port.monitor --webprints the same link,monitor --web work-1appends#work=work-1, anddoctor --jsonreportsmonitorUrlwithouttoken=.tests/work-console.test.ts: in Playwright,${url}#work=<second>opens on the second Work Item.pnpm verify: 401 tests, 398 passed, 0 failed (3 live-provider tests skipped).Merge Danger
Door: two-way
Blast Radius: approvals
🤖 Generated with Claude Code