Fixed QueryAsync header handling in facade static class - #1008
Conversation
Inverted the hasHeader flag before forwarding it to the Excel and CSV importers from the MiniExcel facade class because their APIs use the opposite semantics.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe generic ChangesQueryAsync header forwarding
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to Generic asynchronous typed queries now correctly map header handling to the importer APIs for both file paths and streams, without changing stream ownership. No current merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Inverted the hasHeader flag before forwarding it to the Excel and CSV importers from the MiniExcel facade class because their APIs use the opposite semantics.
Resolves #1007
Summary by CodeRabbit