Repository navigation
build(deps): bump bpmn-to-code to 6.6.1 and migrate to the 6.x api - #13
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
bpmn-to-code 6.x replaces the per-category nested classes (
Elements,Variables,ServiceTasks,Messages,Errors) with a node-centric API. Staying on 5.2.0 keeps this blueprint out of step with the sibling engine blueprints that are already on 6.6.1.What
bpmn-to-code.versionfrom 5.2.0 to 6.6.1 (plugin,bpmn-to-code-runtime,bpmn-to-code-testing).adapter/process. It now holds*ProcessApiwithFlowNodes.<Node>plus the sharedServiceTasks,Messages,ProcessVariables,ErrorsandEscalationsfiles. Element ids are unchanged.LeasingProcessAdapter,TaskInboxAdapter,EngineApiConfigurationand the tests:Elements.X.getValue()becomesFlowNodes.X.ELEMENT_IDVariables.<Node>.XbecomesFlowNodes.<Node>.Variables.XServiceTasks/Messages/Errorsare now imported from the shared filesTimerUtils.fireTimernow takes aFlowNode(same as the cibseven blueprint).ServiceTaskExternalTopicRulechecksTaskImplementation.ExternalTaskinstead of the removed engine-specific property map. The validation test now usesValidationRule.*ProcessApi*is already excluded.Verification
./mvnw -B verifypasses: 155 tests, 0 failures. That covers the architecture, unit, process and model-validation tests plus checkstyle.git statusshows no drift in the generatedadapter/processsources.