feat(analytics): Implement semver and date custom ops for flags runtime props - #104
Open
efahk wants to merge 3 commits into
Open
feat(analytics): Implement semver and date custom ops for flags runtime props#104efahk wants to merge 3 commits into
efahk wants to merge 3 commits into
Conversation
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains; the previously reported duplicate test artifact is absent from the current tree.
|
| Filename | Overview |
|---|---|
| src/main/java/com/mixpanel/mixpanelapi/featureflags/util/CustomOperators.java | Implements validated SemVer and RFC3339 datetime comparisons. |
| src/main/java/com/mixpanel/mixpanelapi/featureflags/util/JsonLogicEngine.java | Registers the new operators during JSON Logic engine initialization. |
| src/test/java/com/mixpanel/mixpanelapi/featureflags/util/CustomOperatorsTest.java | Executes both golden-vector suites through the production evaluation path. |
Reviews (3): Last reviewed commit: "hand roll semver and update tests" | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Semantic Versioning and RFC3339 date comparison support for feature flags runtime event matching. This implements them as extensions to the JSONLogic library that is being used for targeting.
See here for more information about the comparators and golden vector list