Skip to content

⚡ Bolt: Optimize hardware entity lookups in Lua API - #272

Open
mleem97 wants to merge 1 commit into
mainfrom
bolt/optimize-lua-api-3209481188343204022
Open

mleem97 wants to merge 1 commit into
mainfrom
bolt/optimize-lua-api-3209481188343204022

Conversation

@mleem97

@mleem97 mleem97 commented Sep 13, 2026

Copy link
Copy Markdown
Owner

💡 What: Replaced O(N) FindObjectsOfType<Il2Cpp.Server> calls with O(1) dictionary lookups from NetworkMap.instance in LuaServerModule. Added early exit for empty racks in LuaRackModule.
🎯 Why: The Lua API methods are frequently polled by scripts, causing excessive CPU overhead and GC pressure when searching the entire object hierarchy.
📊 Impact: Eliminates expensive full-scene scans for server lookups and avoids scans entirely when racks are empty, significantly improving framerate during intensive script execution.
🔬 Measurement: Profile the execution time of greg.server.get_all(), greg.server.repair_all(), and greg.rack.get_all() from Lua scripts before and after the change. Ensure tests pass locally.


PR created automatically by Jules for task 3209481188343204022 started by @mleem97

@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 13, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review Completed 2026-09-13T00:15:51.442565Z c107ddb PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codacy-production

Copy link
Copy Markdown

Not up to standards ⛔

🔴 Issues 2 high

Alerts:
⚠ 2 issues (≤ 0 issues of at least minor severity)

Results:
2 new issues

Category Results
Security 2 high

View in Codacy

🟢 Metrics 24 complexity · 4 duplication

Metric Results
Complexity 24
Duplication 4

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant