Repository navigation
fix(setup): run Kimi hooks through bash.exe on Windows - #180
Merged
Merged
Conversation
Kimi Code runs hook commands natively on Windows, so a bare .sh path fails under cmd or opens the .sh file association, a Git Bash window on every hook event. On Windows, register each command as "<Git bash.exe>" "<script.sh>", resolving Git for Windows' bash and skipping the System32 WSL launcher. Other platforms keep the bare path. Fixes mnemon-dev#178
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
On Windows,
mnemon setup --target kiminow registers each hook as"<Git bash.exe>" "<script.sh>"instead of a bare.shpath. It finds Git for Windows' bash and skips the System32 WSL launcher. Other platforms are unchanged.Why
Fixes #178. Kimi Code runs the hook command natively, so the bare path failed under
cmdor opened a Git Bash window on every hook event. This is the first fix proposed in the issue.Checklist
make test): nomakeon my Windows box, so I ran its parts.GOOS=linux go vet ./...is clean andgo test ./internal/memory/setup -run Kimipasses 5 of 5. The other Windows failures in that package are identical on master.make test-integration, when affected): not affected