Repository navigation
fix(setup): stop the Pi extension repeating the guide as a visible message - #181
Merged
Merged
Conversation
…ssage The Pi extension returned the full guide with display=true on every turn and also notified the user after every reply. Pi renders only display=true messages but always passes the message to the model, so the guide is now a hidden message marked in its details. Before each turn the extension looks for that marker in the current session branch, honouring the compaction cut-off, and sends only a one-line reminder when the guide is still in context. A new session, compaction, or /tree navigation that drops the guide sends it again, as does an unreadable branch. The agent_end notification is removed because the injected reminder already carries it. Fixes mnemon-dev#177
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The Pi extension now injects the guide as a hidden message (
display: false) and sends it only when the current session branch does not already hold it. Later turns get the one-line reminder. The per-replyagent_endnotification is removed.Why
Fixes #177. I check the branch instead of tracking the session id because compaction and
/treedrop the guide without firingsession_startor changing the id, so an id flag would leave the model without the guide for the rest of the session.Checklist
make test): nomakeon my Windows box, so I ran its parts.GOOS=linux go vet ./...is clean,go test ./internal/memory/setup -run Piandgo test ./test/memory/pipass, andextension.test.mjspasses 32 of 32.make test-integration, when affected): not run/tree, unreadable branch, noagent_endhookagent_enddropped from the README event lists