Repository navigation
Say what ending a session discards, however it ends (CHALLENGES 388) - #331
Merged
Merged
Conversation
Fixes #328. app_session answers discarded, and all five clients warn on quit. A client that exits without quit has the pipe say it. A recording and a trace now leave audio's note, so a later stop names the cause. Measured with a running recording: all five clients on the Android 15 emulator, Python on the iOS 26.5 simulator. Three lost recordings warned once in Python before and three times now; -W ignore still silences it. Exit without quit and kill -9 say it on standard error. A speech listen is covered by a test only. record, trace, files, clients, test-runner pass on Android; trace and audio-sim on iOS. audio.sh fails 2 of 3 on main and on this branch alike, on a tone split by a short dropout. A recording the CLI started is still ended by a client's quit, now with the warning. mobium test over a running recording kept it, 1 run.
lana-20
added a commit
that referenced
this pull request
Nov 5, 2026
#331 added these notes beside audio's. clean-stop took them for a daemon left running, with nothing running, and --quit could not clear them. Measured with 4 notes left by real runs: clean before reading them as a daemon, and a fake socket beside them still fails the check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #328.
283 made
session endsay what it discards, but only in its text. Every client dropped the answer, so a recording was lost at exit 0.What changes
app_sessionandapp_shutdownanswerdiscarded. The list also names a running trace and a speech listen. A trace was lost at session end with no word.MobiumWarning, Go the standard logger, Java thedev.mobiumlogger, .NET standard error.-W ignorestill silences it, and the warning points at the caller's line.kill -9included, has the pipe say it on standard error.daemon stop, a driver switch, a shutdown.Measured
With a running recording: all five clients on the Android 15 emulator; Python, exit without quit and a trace on the iOS 26.5 simulator. pytest shows the warning in its summary. With the recording stopped first, nothing is said.
record,trace,files,clientsandtest-runnerpass on Android;traceandaudio-simon iOS.Not settled here
start()reuses a session the CLI opened, and its quit ends it, somobium recordcannot film a client's run. It now warns, and the CLI's stop names why.mobium testover a running recording kept it, 1 run. The earlier lead did not reproduce.audio.shfails 2 of 3 onmainand on this branch alike, on a tone split by a short dropout. That is not this change.