Skip to content

Say what ending a session discards, however it ends (CHALLENGES 388) - #331

Merged
lana-20 merged 1 commit into
mainfrom
quit-says-what-it-discards
Nov 5, 2026
Merged

lana-20 merged 1 commit into
mainfrom
quit-says-what-it-discards

Conversation

@lana-20

@lana-20 lana-20 commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Fixes #328.

283 made session end say what it discards, but only in its text. Every client dropped the answer, so a recording was lost at exit 0.

What changes

  • app_session and app_shutdown answer discarded. The list also names a running trace and a speech listen. A trace was lost at session end with no word.
  • Each client's quit warns: Python and JavaScript a MobiumWarning, Go the standard logger, Java the dev.mobium logger, .NET standard error.
  • Python warns every time. Its default shows a warning once per place, so three lost recordings warned once. -W ignore still silences it, and the warning points at the caller's line.
  • A client that exits without quit, kill -9 included, has the pipe say it on standard error.
  • A recording and a trace leave audio's lost-capture note (280). A later status or stop names the cause instead of "nothing is recording": another client's quit, daemon stop, a driver switch, a shutdown.

Measured

With a running recording: all five clients on the Android 15 emulator; Python, exit without quit and a trace on the iOS 26.5 simulator. pytest shows the warning in its summary. With the recording stopped first, nothing is said.

record, trace, files, clients and test-runner pass on Android; trace and audio-sim on iOS.

Not settled here

  • A speech listen is covered by a test alone: TalkBack on this emulator does not log at VERBOSE.
  • A client's start() reuses a session the CLI opened, and its quit ends it, so mobium record cannot film a client's run. It now warns, and the CLI's stop names why.
  • mobium test over a running recording kept it, 1 run. The earlier lead did not reproduce.
  • audio.sh fails 2 of 3 on main and on this branch alike, on a tone split by a short dropout. That is not this change.

Fixes #328. app_session answers discarded, and all five clients warn on quit. A
client that exits without quit has the pipe say it. A recording and a trace now
leave audio's note, so a later stop names the cause.

Measured with a running recording: all five clients on the Android 15 emulator,
Python on the iOS 26.5 simulator. Three lost recordings warned once in Python
before and three times now; -W ignore still silences it. Exit without quit and
kill -9 say it on standard error. A speech listen is covered by a test only.

record, trace, files, clients, test-runner pass on Android; trace and audio-sim
on iOS. audio.sh fails 2 of 3 on main and on this branch alike, on a tone split
by a short dropout.

A recording the CLI started is still ended by a client's quit, now with the
warning. mobium test over a running recording kept it, 1 run.
@lana-20
lana-20 merged commit 6bcd5e8 into main Nov 5, 2026
10 checks passed
@lana-20
lana-20 deleted the quit-says-what-it-discards branch November 5, 2026 02:42
lana-20 added a commit that referenced this pull request Nov 5, 2026
#331 added these notes beside audio's. clean-stop took them for a daemon left
running, with nothing running, and --quit could not clear them.

Measured with 4 notes left by real runs: clean before reading them as a daemon,
and a fake socket beside them still fails the check.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A client's quit() discards a running recording without a word

1 participant