Repository navigation
Conversation
On-demand installers update the auto-allow map while concurrent device queries read it. The per-kind installation locks do not protect these reads or writes from installers for other kinds, allowing data races and concurrent map access panics. Protect shared map access with a read/write mutex while retaining the per-kind installation locks. Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
fix-cdi-autoallow-race
branch
from
October 17, 2026 15:23
63f1a2d to
a34ac4e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completing an on-demand CDI installation updates the manager shared
autoAllowedmap while concurrent builds or worker queries can read it throughGetDeviceandListDevices. The existing installation locks are scoped to individual device kinds, so they neither synchronize these readers nor prevent installers for different kinds from writing concurrently. This creates a data race and can crash the daemon with a concurrent map access error. Protect the map with a shared read/write mutex, keeping installation work outside that lock and preserving the existing per-kind installation locks and permission behavior.I found that while reviewing the on-demand setup path in #7293