Conversation
|
I'll fix CI failures and address comments from users with write access that start with 'Devin'.
|
devin-ai-integration
Bot
force-pushed
the
devin/1790764407-execute-sample-target-inputs
branch
from
September 30, 2026 20:25
f31f1c6 to
4f07cb5
Compare
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
devin-ai-integration
Bot
force-pushed
the
devin/1790764407-execute-sample-target-inputs
branch
from
September 30, 2026 20:48
4f07cb5 to
4b4c335
Compare
kevintli
added this pull request to stack #13
September 30, 2026 22:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When only
max_inputs=128is set, Modal's autoscaler aims for 128 in-flight inputs per container. So a client with ~500 concurrentasamplecalls (sec-search-rl: 64 groups x 8) ran on 1–2execute_samplecontainers. Each container pulls inputs oneFunctionGetInputsround-trip at a time, which made intake the bottleneck. Under load the function had a backlog of 100–200 while SGLang replicas sat almost idle, and mostretrieve_futurelong-polls timed out (408).Setting
target_inputs=16makes the autoscaler spread that load across ~30 cheap CPU containers.max_inputs=128stays the burst ceiling. On the sec-search-rl traj-recall run (stacked on #8, deployed tokevinli-spindle-secrepro), throughput went from ~4 to ~26asample/s at the frontend (21 runners, backlog 0), and 408s dropped from the majority ofretrieve_futureresponses to ~3%.tests/providers/test_modal_app.pypasses.Link to Devin session: https://modal.devinenterprise.com/sessions/f53cfabb210146de8f0338fe388d7973
Open in Devin Desktop: https://modal.devinenterprise.com/desktop/session/f53cfabb210146de8f0338fe388d7973?variant=devin
Requested by: @kevintli