Repository navigation
Fix SSE endpoint discovery hanging - #1057
mikemikimike wants to merge 5 commits into
Conversation
4e546e0 to
1693108
Compare
There was a problem hiding this comment.
Thanks for taking this on — I left a couple of things that need a fix before merge, and one smaller note.
Produced by Air Automations. Name: Code review / Run: https://air.jetbrains.cloud/org/05cf1a7f-6ab5-713b-abd3-29d0c8a05e2d/automations/409567ec-d3a7-40ac-ba95-8518ec577ac2?run=d102c483-a84d-4345-ace2-7612a915245e
There was a problem hiding this comment.
Everything from the last round is addressed and verified — nice work, this is good to go!
Produced by Air Automations. Name: Code review / Run: https://air.jetbrains.cloud/org/05cf1a7f-6ab5-713b-abd3-29d0c8a05e2d/automations/409567ec-d3a7-40ac-ba95-8518ec577ac2?run=2e253ba9-7c52-4e5b-9511-fd949a743f31
There was a problem hiding this comment.
Everything from the previous rounds checks out on this revision — approving!
Produced by Air Automations. Name: Code review / Run: https://air.jetbrains.cloud/org/05cf1a7f-6ab5-713b-abd3-29d0c8a05e2d/automations/409567ec-d3a7-40ac-ba95-8518ec577ac2?run=86dbe2c5-aa8c-4d3b-a84b-f456b4854a05
89344c8 to
82ab6fd
Compare
|
Rebased the branch onto the latest Validation on
All passed. |
There was a problem hiding this comment.
Nice work — the discovery timeout now covers the handshake end to end on a real clock, so this looks good to merge.
Produced by Air Automations. Name: Code review / Run: https://air.jetbrains.cloud/org/05cf1a7f-6ab5-713b-abd3-29d0c8a05e2d/automations/409567ec-d3a7-40ac-ba95-8518ec577ac2?run=fbaa955a-937b-4e5a-828c-a3466d03bfcc
There was a problem hiding this comment.
Lovely work — the discovery timeout holds up across JVM and Native and I found nothing that needs changing, so this is good to merge!
Produced by Air Automations. Name: Code review / Run: https://air.jetbrains.cloud/org/05cf1a7f-6ab5-713b-abd3-29d0c8a05e2d/automations/409567ec-d3a7-40ac-ba95-8518ec577ac2?run=8943f085-4afd-4a2e-8e67-78e6bf492f7c
Summary
Fixes #1033
Fixes #1033
Issue: #1033
Tests
./gradlew :kotlin-sdk-client:jvmTest --tests io.modelcontextprotocol.kotlin.sdk.client.sse.SseClientTransportTest
./gradlew :integration-test:jvmTest --tests io.modelcontextprotocol.kotlin.sdk.client.SseTransportTest :integration-test:linuxX64Test --tests io.modelcontextprotocol.kotlin.sdk.client.SseTransportTest
./gradlew :kotlin-sdk-client:ktlintCommonMainSourceSetCheck :kotlin-sdk-client:ktlintCommonTestSourceSetCheck :kotlin-sdk-client:detektJvmMain checkKotlinAbi
./gradlew kotlinWasmNpmInstall kotlinWasmToolingSetup --no-daemon --rerun-tasks