Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 12e637eae2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![jetbrains-air[bot]](https://avatars.githubusercontent.com/in/3314082?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thanks for digging into this one — approving.
Produced by Air Automations. Name: Code review / Run: https://air.jetbrains.cloud/org/05cf1a7f-6ab5-713b-abd3-29d0c8a05e2d/automations/409567ec-d3a7-40ac-ba95-8518ec577ac2?run=8b1db71a-b823-4ad6-b3ac-375879c99bf8
There was a problem hiding this comment.
Looks good now — approving.
Produced by Air Automations. Name: Code review / Run: https://air.jetbrains.cloud/org/05cf1a7f-6ab5-713b-abd3-29d0c8a05e2d/automations/409567ec-d3a7-40ac-ba95-8518ec577ac2?run=32481b2f-788c-4abe-ae79-f82ad76e66dc
There was a problem hiding this comment.
Happy to approve this one — no blocking findings.
Produced by Air Automations. Name: Code review / Run: https://air.jetbrains.cloud/org/05cf1a7f-6ab5-713b-abd3-29d0c8a05e2d/automations/409567ec-d3a7-40ac-ba95-8518ec577ac2?run=3086f0f3-04cc-4733-be5e-5770eac22142
There was a problem hiding this comment.
Nicely done on the cancellation handling — approving.
Produced by Air Automations. Name: Code review / Run: https://air.jetbrains.cloud/org/05cf1a7f-6ab5-713b-abd3-29d0c8a05e2d/automations/409567ec-d3a7-40ac-ba95-8518ec577ac2?run=27f56692-74d6-43bb-9bb3-8ea7ee4a5a1b
There was a problem hiding this comment.
All three earlier findings are properly resolved and the full JVM suite is green here — happy to approve this one!
Produced by Air Automations. Name: Code review / Run: https://air.jetbrains.cloud/org/05cf1a7f-6ab5-713b-abd3-29d0c8a05e2d/automations/409567ec-d3a7-40ac-ba95-8518ec577ac2?run=61d88fba-3abc-440c-8ae3-c5e4e865dc1f
Fix client send failures being reported both through an exception and through
onError.Motivation and Context
Fixes #1034.
When sending an error reply fails,
AbstractClientTransport.send()reports the failure and throws it, thenProtocolreports it again. HTTP status and response-parsing failures add their own duplicate reports. Let these synchronous send failures propagate to their caller, preserving exception wrapping, causes and cancellation. Background errors and non-throwing SSE error events still useonError.How Has This Been Tested?
main; all 45 focused tests pass with the fix.ktlintCheckpasses.checkKotlinAbipasses.Breaking Changes
No public signatures or wire formats change. Callback behavior changes as requested in #1034: callers handle thrown send failures, and
onErrorno longer repeats those failures. Background error reporting is preserved.Types of changes
Checklist
Additional context
Prepared with Codex assistance for investigation, implementation and local validation.
Core/client Detekt tasks exit successfully. The core analyzer reports 110 compiler-resolution errors on both this branch and pristine
main(dbea361), so that pre-existing warning limits its analysis accuracy.