Skip to content

Verify signed MCPB bundles #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jstar0 wants to merge 2 commits into
base: main
Choose a base branch
from
+325 −119
Open

Verify signed MCPB bundles #286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be82018
Verify signed MCPB bundles
jstar0 Jun 19, 2026
df14718
Fix MCPB signature verification
jstar0 Oct 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions src/cli/cli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,13 @@ program
);
console.log(`Fingerprint: ${result.fingerprint}`);
} else {
console.error(`ERROR: Extension is not signed`);
const errorMessage =
result.status === "unsigned"
? "Extension is not signed"
: result.status === "invalid"
? "Signature is invalid"
: "Signature is valid, but the certificate is not trusted";
console.error(`ERROR: ${errorMessage}`);
process.exit(1);
}
} catch (error) {
Expand Down Expand Up @@ -330,8 +336,14 @@ program
);
console.log(` Fingerprint: ${signatureInfo.fingerprint}`);
console.log(` Status: Valid (self-signed)`);
} else {
} else if (signatureInfo.status === "unsigned") {
console.log(`\nWARNING: Not signed`);
} else if (signatureInfo.status === "invalid") {
console.log(`\nWARNING: Signature is invalid`);
} else {
console.log(
`\nWARNING: Signature is valid, but the certificate is not trusted`,
);
}
} catch (error) {
console.log(
Expand Down
Loading