Skip to content

Fix video task failure details in task get and download #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hopelynd wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −4
Open

Fix video task failure details in task get and download #199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/commands/src/commands/video/download.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,15 @@ export default defineCommand({
});

if (taskInfo.output.task_status !== "SUCCEEDED") {
const status = taskInfo.output.task_status;
const detail = taskInfo.output.message || taskInfo.output.code;
const message = detail
? `Task is not complete (status: ${status}): ${detail}`
: `Task is not complete (status: ${status}).`;
throw new BailianError(
`Task is not complete (status: ${taskInfo.output.task_status}).`,
message,
ExitCode.GENERAL,
"Wait for the task to complete before downloading.",
status === "FAILED" ? undefined : "Wait for the task to complete before downloading.",
);
}

Expand Down
10 changes: 8 additions & 2 deletions packages/commands/src/commands/video/task-get.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import {
defineCommand,
taskPath,
detectOutputFormat,
stripUndefined,
type DashScopeTaskResponse,
} from "bailian-cli-core";
import { emitResult, emitBare } from "bailian-cli-runtime";
Expand Down Expand Up @@ -42,15 +43,20 @@ export default defineCommand({
return;
}

// 透传服务端失败字段：FAILED 时 output.code / output.message 是排查依据；request_id 便于工单溯源。
emitResult(
{
stripUndefined({
task_id: response.output.task_id,
task_status: response.output.task_status,
video_url: response.output.video_url,
results: response.output.results,
submit_time: response.output.submit_time,
scheduled_time: response.output.scheduled_time,
end_time: response.output.end_time,
},
code: response.output.code,
message: response.output.message,
request_id: response.request_id,
}),
format,
);
},
Expand Down