Repository navigation
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3158
Why
When the browser websocket closes or errors before opening,
webSocketOpenednever settles.sendMessage()then remains pending and the test runner eventually reports only that browser tests did not start.Reproduction
Run the
web-socketstest with an injected websocket, close the browser-side socket before itsopenevent, then send awtr-session-startedmessage. Before this change, the regression test timed out becausesendMessage()never settled. With the fix, the test receives the websocket connection error immediately.Changes
Checks
npm run build --workspace=@web/parse5-utils— passed.npm run build --workspace=@web/dev-server-core— passed.node --experimental-strip-types --test --test-force-exit test/web-sockets/webSocketsPlugin.test.tsfrompackages/dev-server-core— passed (5 tests).git diff --check— passed.