Repository navigation
fix(serve): give a request that fails pydantic validation an error reason - #38
Merged
Merged
Conversation
…ason Its 400 carried only detail, so a caller reading error got none.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A request that fails pydantic validation is refused with 400, but its body had no
error, the field aValidationErrorrefusal carries. A caller readingerrorgot nothing to show.detailis unchanged. Version 5.2.2.Evidence
c9d58fe):test_an_invalid_request_is_refused_with_a_reason_naming_the_fieldfails withKeyError: 'error'.After: it passes; full suite 93 passed, ruff and ty clean.
Merge Danger
Door: two-way
Blast Radius: small
Adds a field to one error response. A client that branches on
errorbeing absent for this case would now see it.